Karma: Strip Spaces and characters appended to Nicks by clients #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm unconvinced and shall test on instance and write tests. How |
prdes
force-pushed
the
fix_karma_normalize
branch
from
d231bdf
to
fdf28a2
Compare
prdes
changed the title
|
The squash and fixup didnt go perfect. The space, Added tests for the same |
jlu5
requested changes
Nov 17, 2021
| inc = self.registryValue('incrementChars', msg.channel, irc.network) | ||
| dec = self.registryValue('decrementChars', msg.channel, irc.network) | ||
| if msg.args[1].endswith(inc) or msg.args[1].endswith(dec): | ||
| thing = msg.args[1].rstrip(":, ") |
There was a problem hiding this comment.
I don't think this will actually work - if the message ends with ++ or -- as in the default configuration, there is no way it'll also end with one of :, , so this is effectively a no-op.
I think this code should belong in either _doKarma or _normalizeThing so the behaviour is consistent with addressed Karma calls.
|
bad logic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt towards #1495
Issues:
Hardcoded inc/dec chars