New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
right-click harvest crops disabling ability to open backpack/ender pouches/inventory items #87
Comments
no crash log as it doesn't cause a crash, but not sure why other right-click events fail to function after using the hunger overhaul click-to-harvest |
Can you try setting |
Hm, actually, that couldn't cause it. Can you post a full mod list? Do you have any mods installed that might alter how time passes? |
to save time, i removed the 1.7.10 from the mod names. each one was (at the time downloaded) the newest release for compatibility with MC1.7.10 and latest forge [some updates required after forge's liquid update----namely extrautilities] Forge 13.3.1373 |
also foods unplantable is set to false. Also, while i could see how a ticking / time distortion issue could cause input to not function properly, ticking-issues usually result in an immediate crash. I'll run a few more tests to see if anything else in the world causes inventory containers to be un-openable, or what happens under other case-scenarios. |
i'm not familiar with some of the inner workings of the mods i got---if there are any that you think i should remove or temporary disable for testing purposes, let me know. i can take those out, start a new world, and see what happens :) Since this is a personal project, i can't expect anyone else to do the heavy lifting for me. but any suggestions or insight would be VERY helpful |
I know randomThings2.2.4 adds in bloodmoon, though i'm not sure if that sets daylightCycles to false during a bloodmoon or not---not sure how that works. |
The issue is HO is using an unfortunate workaround for client-server desync due to some Forge bugs with the right click event. // slightly hacky workaround:
// if RIGHT_CLICK_BLOCK is canceled or useItem == Result.DENY, then
// the right click falls through to RIGHT_CLICK_AIR. To correctly cancel the RIGHT_CLICK_AIR,
// we need to make sure that it is happening on the same tick that the right click was performed
if (event.action == PlayerInteractEvent.Action.RIGHT_CLICK_AIR && lastRightClickCrop == event.world.getWorldTime())
{
event.setCanceled(true);
} And, if this is what's being triggered (which it seems to be the most likely cause), then that means that somehow So, that's my theory, and if it's true, it's a pretty crazy incompatibility that might be difficult to track down. Can you do me a favor and try reproducing the bug with just AppleCore, HO, and ExtraUtilities (or whatever mod you want that adds a bag that is affected)? |
I figured it out (or at least, i think i did) On Fri, May 1, 2015 at 4:23 PM, Ryan Liptak notifications@github.com
|
so maybe add an info to the config file next to the "right-click-to-harvest" that doDaylightCycles must not be disabled. because the way your function is written, it appears to cancel right-click events if a crop was the last thing clicked on and the time hasn't incremented. (or at least, thats what i think the function does. i'm no java-expert) |
i'll continue testing this over the next few days just to be sure, but i'm pretty certain now that this is all it was. |
Very interesting, will look into that more and see if I can make it work with doDaylightCycle = false. Thank you for tracking it down. |
Fixed by #104 |
custom modpack that contains a lot of mods, but if i enable click-to-harvest, and then do-so in-game, thereafter i am unable to open my golden bag, ender pouch, or inventory container i'm holding without closing the client and rebooting. Problem is, i rather LOVE the click-to-harvest option and it makes harvesting food not a total pain in the ass...
without it, and to have spice of life enabled, makes getting food items take up all my time...
and if i remove those, it makes minecraft too easy again....
The text was updated successfully, but these errors were encountered: