Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Natura crops, bush, cactus growing not using Forge's onCropsGrowPre/Post events, breaking compatibility with some mods #455

Closed
Stormwind99 opened this issue Jun 22, 2018 · 2 comments

Comments

@Stormwind99
Copy link
Contributor

(I'll be submitting a pull request with the fix shortly.)

Version Information

Minecraft: 1.12.2
Forge: N/A
Mantle: N/A
Natura: 1.12 branch from GitHub

Report Information

Natura's crop, bush, and cactus growing is not using Forge's onCropsGrowPre and onCropsGrowPost events, breaking compatibility with other mods like Serene Seasons.

Steps to Reproduce

N/A since issue is in code. An example is non-compatibility with Serene Seasons - all other crops stop growing in winter, but Natura's crops continue to grow.

Crash Log

N/A

Forge Log

N/A

@Stormwind99
Copy link
Contributor Author

Related #442

Stormwind99 added a commit to Stormwind99/Natura that referenced this issue Jun 22, 2018
…ge's onCropsGrowPre/Post events, breaking compatibility with some mods
@Stormwind99
Copy link
Contributor Author

Fixed in #456

alexbegt pushed a commit that referenced this issue Jul 22, 2018
* Fix for #455 Natura crops, bush, cactus growing not using Forge's onCropsGrowPre/Post events, breaking compatibility with some mods

* Fix for gradle project name from nature to Natura - was breaking gradle project import into Eclipse

* Possible fix for Github markdown not being detected by Github for README.md formatting

* Review change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants