-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ghostwood not generating #221
Conversation
@progwml6 just tested, this PR solves ghostwood not generating. @Sinhika is it possible to add some kind of check for tree leaves that there are no blocks nearby (block is an air?) and only then generate the tree? And that block under the tree is not an air? (Block is dirt or netherrack for Nether Trees) Because I found tigerwood one block up from the dirt. |
@Adaptivity It is my understanding that progwml6 & others are re-writing the tree generation section; I'd wait and see how that comes out and if it needs fine-tuning. This was just a quick fix so that people who had been looking for ghostwood trees since 1.7.10 came out would have something to tide them over until progwml6 & them could backport 1.8 re-write/re-design to 1.7.10. Also I am not part of the regular Natura team; I'm just a coder who cloned the open source code, fixed a problem that was personally annoying me, my kid, and various others, and sent in a pull request with the fix. |
2 things: my appologies for not getting to this earlier |
Oops! I did not realize it would automatically add the change to the pull request (not until I did the Botania thing last week, anyway). I thought the PR would stay pointed at a particular git snapshot. So, how do you want me to handle this? Back out the other change and put it on a different branch? |
@progwml6 can I ask why you can't accept configuration for mobs spawning? Mobs still enabled by default and people can disable them if they want. So, what's the problem? Does this break gameplay or what? |
mDiyo asked that they not be able to be disabled when I first started working on natura.
|
Okay, I think I finally got GitHub sorted out. I am going to re-submit this pull request with a branch that features the necessary fix and only the necessary fix. I apologize for the complications; I'm still getting used to GitHub's interface when it comes to doing anything more complicated than cloning a project and checking in and out on the master branch. Fortunately, the online Git book is quite helpful when it comes to figuring out how to use the git command-line interface to sort out this mess. |
Fixed ghostwood not generating. Fixed merge so that only relevant code file is changed, not build files.