Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase accuracy with omerc projection #317

Merged
merged 6 commits into from Jan 21, 2021
Merged

Increase accuracy with omerc projection #317

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1523223
Initial work to increase accuracy with omerc projection
dulldrums Apr 15, 2019
9d488df
update omerc projection names, update failing omerc tests
dulldrums Apr 16, 2019
eab6854
fix issue where units other than meters would cause issues with scaling
dulldrums Apr 24, 2019
502aad0
Fix issues with Type A and Type B omerc projections, add more omerc …
dulldrums May 14, 2019
ded41da
add tests for EPSG:3468, update accuracy of some omerc Type A tests
dulldrums May 14, 2019
587ddd5
added test for omerc using unit: Foot_US
dulldrums May 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/projections/omerc.js
View file
Open in desktop
Expand Up @@ -181,8 +181,8 @@ export function inverse(p) {
var u, v, Qp, Sp, Tp, Vp, Up;
var coords = {};

p.x = (p.x * this.to_meter - this.x0) * (1.0 / this.a);
p.y = (p.y * this.to_meter - this.y0) * (1.0 / this.a);
p.x = (p.x - this.x0) * (1.0 / this.a);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we going to need to add some tests for non meter omerc projections ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think so.

I'll get back to this PR sometime next week, got pulled into some other stuff.

p.y = (p.y - this.y0) * (1.0 / this.a);

if (this.no_rot) {
v = p.y;
Expand Down