-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed my answer to the amd question #32
Conversation
Cool, I'll take a look later this week or early next. |
so since I had to rewrite the test anyway I'm now going through and making sure each projection type is hit with a test |
ok you can now specify a custom build e.g. |
you can also separate multiple ones with a comma |
@ahocevar this is mergable from a technical perspective, we may want to discus if it's the right direction though |
Thanks @calvinmetcalf for your work on this. I'll take a closer look as soon as I get to it. |
@@ -0,0 +1,405 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better to use the npm package?
yes that would make more sense, fixed |
I feel like this is good to merge now, but the pull request seems to include many unrelated commits. Maybe a rebase issue? |
ok I'll try |
If you can update the pull request description to give a summary of all changes, we can also keep all commits in this pull request. Whatever is easier. |
…ng almond from npm
rebased it with more descriptive commit messeges |
Thanks for your continued effort on this! I think this is in great shape now. |
Changed my answer to the amd question
@calvinmetcalf What should we do with |
added to gitignore |
Done with 8c5275a. |
re #20 I changed my answer
got it working too, though ugly as sin and probably would need some help by someone who uses amd modules.