Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing to query container runtime in test workflow on MicroK8s [SAME VERSION] #202

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Fix failing to query container runtime in test workflow on MicroK8s [SAME VERSION] #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c368be5
loop query containerd several times instead of sleeping
kate-goldenring Jan 12, 2021
69a6fbc
shorten agent log query
kate-goldenring Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/run-test-cases.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,8 @@ jobs:
- if: (startsWith(github.event_name, 'pull_request')) && (startsWith(matrix.kube-runtime, 'MicroK8s'))
name: Import local agent and controller to MicroK8s
run: |
sleep 15 # 60, 30, 15, and 5 all work in simple tests ... no sleep fails for 1.19.3
sudo microk8s.status --wait-ready
until sudo microk8s ctr images ls; do sleep 5s; echo "Try again"; done
sudo microk8s ctr images ls
sudo microk8s ctr --debug --timeout 10s images import agent.tar
sudo microk8s ctr --debug --timeout 10s images import controller.tar
Expand Down
2 changes: 1 addition & 1 deletion test/run-end-to-end.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def do_test():
print("Failed to get logs from {} pod with result {} on attempt {} of 3".format(shared_test_code.agent_pod_name, log_result, x))
if x == 2:
return False
grep_result = subprocess.run('grep "get_node_slots - crictl called successfully" {} | wc -l | grep -v 0'.format(temporary_agent_log_path), shell=True)
grep_result = subprocess.run(['grep', "get_node_slots - crictl called successfully", temporary_agent_log_path])
if grep_result.returncode != 0:
print("Akri failed to successfully connect to crictl via the CRI socket with return value of {}", grep_result)
# Log information to understand why error occurred
Expand Down