Only compile embedded_discovery_handlers module with agent-full flag
#396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-goldenring
requested review from
bfjelds,
Britel,
jiria and
romoh
as code owners
romoh
approved these changes
Oct 1, 2021
Saran51
approved these changes
Oct 1, 2021
vincepnguyen
pushed a commit
that referenced
this pull request
Nov 23, 2021
#396) Signed-off-by: vincepnguyen <70007233+vincepnguyen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This more explicitly declares when code for embedded discover handlers should be compiled. This helps remove
clippywarnings ref #383 and makes sure code is only compiled when needed.If applicable:
cargo fmt)cargo build)cargo clippy)cargo test)cargo doc)./version.sh)