Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes Test Versions Update #513

Merged
merged 8 commits into from Oct 12, 2022

Conversation

adithyaj
Copy link
Collaborator

@adithyaj adithyaj commented Sep 19, 2022

What this PR does / why we need it:
Fixes #509, the test matrix was using older EOL versions of Kubernetes. This PR updates K8s to use the most recently EOL'd version (1.21) and adds all currently released versions (1.22-1.25).

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

Signed-off-by: Adithya J <adjayach@microsoft.com>
@adithyaj adithyaj marked this pull request as ready for review September 19, 2022 07:07
@adithyaj adithyaj marked this pull request as draft September 19, 2022 08:02
@adithyaj
Copy link
Collaborator Author

adithyaj commented Sep 20, 2022

Updating here - Kubernetes 1.22 and 1.23 are failing to init on the test pipeline and at first glance it looks like it could be because of the changes to containerd defaults. I'm going to test locally with a clean image of ubuntu 18.04 to get a better idea of the failure.

@adithyaj
Copy link
Collaborator Author

@Rishit-dagli do you know if containerd is a drop in replacement for dockershim? I see with #508 we replaced every reference to dockershim with the containerd path but is there any other diff we should expect? I think some of our testing still uses docker elsewhere

Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>
Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>
@adithyaj
Copy link
Collaborator Author

adithyaj commented Sep 30, 2022

Updating here - was able to get it to work up to k8s 1.23 🎉
A few changes were needed to get the images we built loaded for containerd + getting kubernetes to use containerd by default.

v1.24 and v1.25 are next

@adithyaj adithyaj marked this pull request as ready for review October 4, 2022 21:20
Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>
Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>
Signed-off-by: Adithya Jayachandran <adithyajay@gmail.com>
@adithyaj
Copy link
Collaborator Author

/version patch

@github-actions github-actions bot added the version/patch Patch version change is needed label Oct 11, 2022
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@adithyaj
Copy link
Collaborator Author

/version patch

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kate-goldenring
Copy link
Contributor

Why aren't the end to end tests running in this PR? A bit strange. Hard to confirm the changes :(

@adithyaj
Copy link
Collaborator Author

adithyaj commented Oct 12, 2022

Why aren't the end to end tests running in this PR? A bit strange. Hard to confirm the changes :(

They ran before I did the version bumps, if you go to the last commit before the version bumps and click on the X next to the commit message you should see it all passing minus the version changes here. Not sure why they didn't show up though :(

@kate-goldenring
Copy link
Contributor

Why aren't the end to end tests running in this PR? A bit strange. Hard to confirm the changes :(

They ran before I did the version bumps, if you go to the last commit before the version bumps and click on the X next to the commit message you should see it all passing minus the version changes here. Not sure why they didn't show up though :(

aha thank you!

Copy link
Contributor

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I know it probably took a fair bit of head-banging trial and error.

@adithyaj adithyaj merged commit f9e89c3 into project-akri:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version/patch Patch version change is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub tests run on EOL versions of K8s
3 participants