Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodeSelectors for Akri Agent #536

Merged

Conversation

jbpaux
Copy link
Contributor

@jbpaux jbpaux commented Nov 3, 2022

What this PR does / why we need it:
It adds nodeSelectors on the Agent to ensure the pod is deployed on specific node.
It closes #414

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

Signed-off-by: Jean-Benoit Paux <9682558+jbpaux@users.noreply.github.com>
@jbpaux
Copy link
Contributor Author

jbpaux commented Nov 3, 2022

/version patch

@github-actions github-actions bot added the version/patch Patch version change is needed label Nov 3, 2022
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbpaux!

Also verified this works selecting for nodename on my cluster with the following:

helm package deployment/helm 
helm install akri akri-0.8.25.tgz --set 'agent.nodeSelectors.kubernetes\.io/hostname=kagold-thinkpad-x1-carbon-6th' --set useLatestContainers=true

@jbpaux
Copy link
Contributor Author

jbpaux commented Dec 1, 2022

Hi,
any opinions ? :)

@kate-goldenring
Copy link
Contributor

kate-goldenring commented Dec 2, 2022

Hi, any opinions ? :)

Thanks for the bump @jbpaux. This is good to merge -- once we bump the version to 0.8.27

@kate-goldenring
Copy link
Contributor

/version patch

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kate-goldenring
Copy link
Contributor

/version patch

github-actions bot and others added 2 commits December 2, 2022 13:39
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kate-goldenring kate-goldenring merged commit 35b4abb into project-akri:main Dec 2, 2022
@jbpaux jbpaux deleted the features/add-node-selector branch December 2, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version/patch Patch version change is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeSelector for Agent in Helm
2 participants