Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubernetes versions in e2e test #573

Merged
merged 3 commits into from Apr 11, 2023

Conversation

harrison-tin
Copy link
Collaborator

What this PR does / why we need it:
Update versions for all 3 Kubernetes distributions in e2e test. Preparing for the April release
Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

Signed-off-by: harrisontin <harrisontin@microsoft.com>
@kate-goldenring
Copy link
Contributor

i dont think we need to bump version in this @harrison-tin since it is not updating any of Akri rather just a test suite. We can instead use the same-version tag on the PR

Copy link
Contributor

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we just need to remove the version bump and then LGTM

@yujinkim-msft yujinkim-msft merged commit e342352 into project-akri:main Apr 11, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants