udev: Improve testability and tests #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diconico07
requested review from
bfjelds,
kate-goldenring,
jiria,
Britel,
romoh and
adithyaj
as code owners
diconico07
force-pushed
the
improve-udev-handler-tests
branch
2 times, most recently
from
951459e
to
ffb24d8
Compare
|
Thanks @diconico07! Can we add a test of trying to insert a device that has already been inserted (namely the upper most parent) just to ensure there is no duplication in the case where a second udev rule matches with the same device as the first. |
|
Thanks @kate-goldenring you just found a missing piece in the implementation 😅 . |
diconico07
force-pushed
the
improve-udev-handler-tests
branch
from
ffb24d8
to
fac88f0
Compare
kate-goldenring
approved these changes
May 10, 2023
|
@diconico07 feel free to bump the version and merge whenever |
As indicated in project-akri#564 the new grouping behavior could get more test coverage. This commit moves the grouping logic to a separate function and adds relevant tests. Signed-off-by: Nicolas Belouin <nicolas.belouin@suse.com>
This commit prevents duplicate device node from being listed when multiple rules match the same devices. This fixes a regression introduced by project-akri#564. Signed-off-by: Nicolas Belouin <nicolas.belouin@suse.com>
diconico07
force-pushed
the
improve-udev-handler-tests
branch
from
fac88f0
to
306cff3
Compare
Signed-off-by: Nicolas Belouin <nicolas.belouin@suse.com>
Signed-off-by: Nicolas Belouin <nicolas.belouin@suse.com>
diconico07
force-pushed
the
improve-udev-handler-tests
branch
from
306cff3
to
cffeba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As indicated in #564 the new grouping behavior could get more test coverage.
This PR moves the grouping logic to a separate function and adds relevant tests.
Special notes for your reviewer:
If applicable:
cargo fmt)cargo build)cargo clippy)cargo test)cargo doc)