Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect Onvif filter #604

Merged
merged 2 commits into from Jun 1, 2023
Merged

Fix incorrect Onvif filter #604

merged 2 commits into from Jun 1, 2023

Conversation

jbpaux
Copy link
Contributor

@jbpaux jbpaux commented May 15, 2023

What this PR does / why we need it:
Fix #597 issue by changing incorrect contains to equality
Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

kate-goldenring
kate-goldenring approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the find and fix!

@diconico07
Copy link
Contributor

/version patch

@github-actions github-actions bot added the version/patch Patch version change is needed label May 31, 2023
@diconico07
Copy link
Contributor

Okay, hoped the bot would do magic here, but no. Can you rebase @jbpaux so we have right patch version upgrade and can merge this.

@jbpaux
Fix incorrect Onvif filter
10bca52 
Signed-off-by: Jean-Benoit Paux <9682558+jbpaux@users.noreply.github.com>
@jbpaux
Copy link
Contributor Author

jbpaux commented May 31, 2023

/version patch

@github-actions
Update patch version
2008917 
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@diconico07 diconico07 merged commit ce58a70 into project-akri:main Jun 1, 2023
2 checks passed
@jbpaux jbpaux deleted the fix/filter branch June 1, 2023 21:07
@johnsonshih johnsonshih mentioned this pull request Jun 15, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diconico07 diconico07 diconico07 approved these changes

@kate-goldenring kate-goldenring kate-goldenring approved these changes

@bfjelds bfjelds Awaiting requested review from bfjelds bfjelds is a code owner

@jiria jiria Awaiting requested review from jiria jiria is a code owner

@Britel Britel Awaiting requested review from Britel Britel is a code owner

@romoh romoh Awaiting requested review from romoh romoh is a code owner

@adithyaj adithyaj Awaiting requested review from adithyaj adithyaj is a code owner

@johnsonshih johnsonshih Awaiting requested review from johnsonshih johnsonshih is a code owner

Assignees
No one assigned
Labels
version/patch Patch version change is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Onvif discovery Handler incorrectly filter ip address
3 participants
@jbpaux @diconico07 @kate-goldenring