Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Buster to Bullseye Docker images #607

Merged
merged 3 commits into from Jun 28, 2023

Conversation

jbpaux
Copy link
Contributor

@jbpaux jbpaux commented May 18, 2023

What this PR does / why we need it:
Upgrade container images to Bullseye (with the exception of the intermediate opencv container image)
Part of #606
Special notes for your reviewer:
I'll have a look if doc need to be updated.

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

@kate-goldenring kate-goldenring linked an issue May 19, 2023 that may be closed by this pull request
@jbpaux
Copy link
Contributor Author

jbpaux commented May 24, 2023

Don't merge it before I update the USE_OPENCV_BASE_VERSION after intermediate image has been pushed

@kate-goldenring
Copy link
Contributor

kate-goldenring commented May 26, 2023

Don't merge it before I update the USE_OPENCV_BASE_VERSION after intermediate image has been pushed

@jbpaux, #609 is merged. should be good to update USE_OPENCV_BASE_VERSION. Also i added a do-not-merge flag for cases like this. I can remove it once the env is updated

@jbpaux
Copy link
Contributor Author

jbpaux commented Jun 6, 2023

it should be good but I think the previous intermediate image hasn't been pushed so this one if failing. Maybe the github action is not triggering push well ?

@diconico07
Copy link
Contributor

Indeed the github action skipped the build and push part on merge 😒 , will do a PR to fix that behavior and then build those containers.

@jbpaux
Copy link
Contributor Author

jbpaux commented Jun 10, 2023

/version patch

@github-actions github-actions bot added the version/patch Patch version change is needed label Jun 10, 2023
Signed-off-by: jbpaux <9682558+jbpaux@users.noreply.github.com>
Signed-off-by: jbpaux <9682558+jbpaux@users.noreply.github.com>
@jbpaux
Copy link
Contributor Author

jbpaux commented Jun 23, 2023

Feel free to update version and merge :)

@diconico07
Copy link
Contributor

/version patch

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@diconico07 diconico07 merged commit 08c9ac7 into project-akri:main Jun 28, 2023
2 checks passed
@jbpaux jbpaux deleted the feat/upgrade-bullseye branch June 28, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version/patch Patch version change is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Docker Images from Debian Buster to Bullseye
3 participants