Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add udev e2e tests #637

Merged
merged 1 commit into from Sep 25, 2023
Merged

Add udev e2e tests #637

merged 1 commit into from Sep 25, 2023

Conversation

diconico07
Copy link
Contributor

What this PR does / why we need it:
This PR introduces a new testsuite that ensures the udev Discover
Handler is able to discover a basic device, and a grouped device (if
any available).

Special notes for your reviewer:
This PR is built on top of #623 only the last commit really belongs to this PR

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

@diconico07
Add udev DH e2e tests
56039b4 
This commit introduces a new testsuite that ensures the udev Discover
Handler is able to discover a basic device, and a grouped device (if
any available).

Signed-off-by: Nicolas Belouin <nicolas.belouin@suse.com>
@diconico07 diconico07 marked this pull request as ready for review August 10, 2023 11:38
kate-goldenring
kate-goldenring approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @diconico07! Love how this adds a test for a single device and one with many subdevices!

@diconico07 diconico07 merged commit f01f161 into project-akri:main Sep 25, 2023
16 checks passed
@diconico07 diconico07 deleted the add-udev-tests branch September 25, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kate-goldenring kate-goldenring kate-goldenring approved these changes

@bfjelds bfjelds Awaiting requested review from bfjelds bfjelds is a code owner

@jiria jiria Awaiting requested review from jiria jiria is a code owner

@Britel Britel Awaiting requested review from Britel Britel is a code owner

@romoh romoh Awaiting requested review from romoh romoh is a code owner

@adithyaj adithyaj Awaiting requested review from adithyaj adithyaj is a code owner

@johnsonshih johnsonshih Awaiting requested review from johnsonshih johnsonshih is a code owner

Assignees
No one assigned
Labels
same version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diconico07 @kate-goldenring