Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

condition checks in the store #163

Open
maxbachmann opened this issue Dec 19, 2019 · 3 comments
Open

condition checks in the store #163

maxbachmann opened this issue Dec 19, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@maxbachmann
Copy link
Contributor

the interface store does not check all conditions before showing the skills.

 [SkillManager] Skill "Speller" does not comply to "asrArbitraryCapture" condition, required "True"

when it does not comply to a condition it should not even appear in the store
@maxbachmann maxbachmann added the bug Something isn't working label Dec 19, 2019
@Psychokiller1888
Copy link
Member

No, it does not and it's intended, because these are settings you can change. Maybe displaying the conditions with a check mark?

@maxbachmann
Copy link
Contributor Author

yeah and when it fails maybe show the reason in the web interface. Right now he will see that it failed and then has to check the logs

@maxbachmann
Copy link
Contributor Author

and he should not be able to install -> maybe show them and hide the install button when it is not possible to install due to the settings

@Psychokiller1888 Psychokiller1888 added enhancement New feature or request and removed bug Something isn't working labels Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Psychokiller1888 @maxbachmann