Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Type Rewrite #47

Open
wants to merge 44 commits into
base: develop
Choose a base branch
from
Open

Resource Type Rewrite #47

wants to merge 44 commits into from

Conversation

jkunstwald
Copy link
Contributor

  • Breaking: Remove in-line description/info field from resource types

    • These infos are now accessed via the PHI backend whenever required
    • pr::buffer and pr::texture are now both just as small as phi::handle::resource at 4 byte
    • Simplifies storage, makes view types like phi::buffer_address etc. simpler
    • While the .info field wasn't explicitly public API, it is a breaking change nonetheless
  • Add cache freeing after frame submit

    • Frame: free_to_cache_after_submit
  • Make vertex and index offsets arguments to all Frame draw methods

    • remove Frame set_offset

@jkunstwald jkunstwald marked this pull request as ready for review February 23, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants