Relax restrictions on CLI certificate #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, a reset of the system clock would potentially cause the CLI client to fail to connect to the REST server, since the system clock would typically reset to a time earlier than the validity period of the user certificate. This would result in the TLS handshake failing since the client certificate would be rejected. This change relaxes the certificate checks for the client certificate and only requires that the CLI client send a certificate. While this does make the system slightly less secure, it is only applicable to the listener for the CLI interface. Therefore, this does not expose any new security holes for the REST server.
nirenjan
requested review from
seiferteric,
jeff-yin,
arunsundark and
joyas-joseph
arunsundark
approved these changes
Feb 11, 2020
jeff-yin
approved these changes
Feb 13, 2020
seiferteric
reviewed
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, a reset of the system clock would potentially
cause the CLI client to fail to connect to the REST server, since the
system clock would typically reset to a time earlier than the validity
period of the user certificate. This would result in the TLS handshake
failing since the client certificate would be rejected.
This change relaxes the certificate checks for the client certificate
and only requires that the CLI client send a certificate. While this
does make the system slightly less secure, it is only applicable to the
listener for the CLI interface. Therefore, this does not expose any new
security holes for the REST server.