Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] Updating pytest dependency to fix error #80

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

tallamjr
Copy link
Contributor

It was discovered in builds from https://github.com/alan-turing-institute/dodo/pull/79
and https://github.com/alan-turing-institute/dodo/pull/78 a failure has occurred on Travis

Command:
$ pytest -rs --ignore=./tests/integration ./tests

Error:
TypeError: attrib() got an unexpected keyword argument 'convert'

It appears that pytest seems to have the package attrs as a dependency.

REF:
https://stackoverflow.com/questions/58189683/typeerror-attrib-got-an-unexpected-keyword-argument-convert

modified:   requirements.txt

@rkm
Copy link
Contributor

rkm commented Oct 16, 2019

If this fixes the CI build for the demo then go ahead and merge it in 👍

I'd like to take a closer look at this before merging back into dev/master later though, as there may be other breaking changes between pytest 4.1 -> 5.2. This should also be specified in the requirements-dev.txt file as well since its a development dependency only.

It was discovered in builds from https://github.com/alan-turing-institute/dodo/pull/79
and https://github.com/alan-turing-institute/dodo/pull/78 a failure has occurred on Travis

Command:
    $ pytest -rs --ignore=./tests/integration ./tests

Error:
    TypeError: attrib() got an unexpected keyword argument 'convert'

It appears that pytest seems to have the package attrs as a dependency.

REF:
    https://stackoverflow.com/questions/58189683/typeerror-attrib-got-an-unexpected-keyword-argument-convert

    modified:   requirements.txt

[SQUASH] Moving pytest bump to requirements-dev instead

Since pytest is only a requirement for development, it should reside in
'requirements-dev.txt' file instead of the main 'requirements.txt' file
	modified:   requirements-dev.txt
	modified:   requirements.txt
@tallamjr
Copy link
Contributor Author

I'd like to take a closer look at this before merging back into dev/master later though, as there may be other breaking changes between pytest 4.1 -> 5.2.

Sounds good 👍 (For your reference this change was of pytest 4.1 -> 5.2 also took place in dodo a couple of weeks ago)

This should also be specified in the requirements-dev.txt file as well since its a development dependency only.

Just updated the commit, 698ba12 should address this

@tallamjr
Copy link
Contributor Author

This PR corrects the initial failing tests outlined in issue #79, but this has revealed further failing tests.

Merging this PR such that a new ticket can be spawned to address these new problems

@tallamjr tallamjr merged commit 33429a4 into nats/issue/113/demo Oct 17, 2019
@rkm rkm deleted the hotfix/79/pytest-failure branch November 21, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants