Skip to content

Commit

Permalink
Fix slow test skipping in CI. (#29097)
Browse files Browse the repository at this point in the history
CI does "--exclude-tags SLOW", but it was not specifying any "--include-tags",
so the harness overwrote the "--exclude-tags" value and we were in fact running
the slow tests when we did not want to be.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Nov 30, 2023
1 parent f58811c commit 052c5fa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/tests/run_test_suite.py
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def main(context, dry_run, log_level, target, target_glob, target_skip_glob,

# If just defaults specified, do not run manual and in development
# Specific target basically includes everything
if 'all' in target and not include_tags:
if 'all' in target and not include_tags and not exclude_tags:
exclude_tags = {
TestTag.MANUAL,
TestTag.IN_DEVELOPMENT,
Expand Down

0 comments on commit 052c5fa

Please sign in to comment.