Skip to content

Commit

Permalink
Fix use of certificate validity policy in CHIPDeviceController. (#26405)
Browse files Browse the repository at this point in the history
In CHIPDeviceControllerFactory we were using the provided validity policy for
our CASE server (i.e. when acting as a CASE responder), but not for our CASE
client (i.e. not when acting as CASE initiator).

As a result, when acting as a CASE client we ended up using the default validity
policy for the NOC provided by the other side, instead of using the one that was
passed in via the FactoryInitParams.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Sep 25, 2023
1 parent 4bcc469 commit 16b7ea3
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions src/controller/CHIPDeviceControllerFactory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -249,12 +249,13 @@ CHIP_ERROR DeviceControllerFactory::InitSystemState(FactoryInitParams params)
stateParams.caseClientPool = Platform::New<DeviceControllerSystemStateParams::CASEClientPool>();

CASEClientInitParams sessionInitParams = {
.sessionManager = stateParams.sessionMgr,
.sessionResumptionStorage = stateParams.sessionResumptionStorage.get(),
.exchangeMgr = stateParams.exchangeMgr,
.fabricTable = stateParams.fabricTable,
.groupDataProvider = stateParams.groupDataProvider,
.mrpLocalConfig = GetLocalMRPConfig(),
.sessionManager = stateParams.sessionMgr,
.sessionResumptionStorage = stateParams.sessionResumptionStorage.get(),
.certificateValidityPolicy = stateParams.certificateValidityPolicy,
.exchangeMgr = stateParams.exchangeMgr,
.fabricTable = stateParams.fabricTable,
.groupDataProvider = stateParams.groupDataProvider,
.mrpLocalConfig = GetLocalMRPConfig(),
};

CASESessionManagerConfig sessionManagerConfig = {
Expand Down

0 comments on commit 16b7ea3

Please sign in to comment.