Skip to content

Commit

Permalink
Rename Accept to ShouldSend
Browse files Browse the repository at this point in the history
  • Loading branch information
andreilitvin committed Jun 16, 2023
1 parent 673b8b0 commit 3365912
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion src/lib/dnssd/minimal_mdns/ResponseSender.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ CHIP_ERROR ResponseSender::PrepareNewReplyPacket()
return CHIP_NO_ERROR;
}

bool ResponseSender::Accept(const Responder & responder) const
bool ResponseSender::ShouldSend(const Responder & responder) const
{
switch (responder.GetQType())
{
Expand Down
2 changes: 1 addition & 1 deletion src/lib/dnssd/minimal_mdns/ResponseSender.h
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ class ResponseSender : public ResponderDelegate

// Implementation of ResponderDelegate
void AddResponse(const ResourceRecord & record) override;
bool Accept(const Responder &) const override;
bool ShouldSend(const Responder &) const override;
void ResponsesAdded(const Responder &) override;

void SetServer(ServerBase * server) { mServer = server; }
Expand Down
4 changes: 2 additions & 2 deletions src/lib/dnssd/minimal_mdns/responders/IP.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ void IPv4Responder::AddAllResponses(const chip::Inet::IPPacketInfo * source, Res
const ResponseConfiguration & configuration)
{
#if INET_CONFIG_ENABLE_IPV4
if (!delegate->Accept(*this))
if (!delegate->ShouldSend(*this))
{
return;
}
Expand Down Expand Up @@ -58,7 +58,7 @@ void IPv4Responder::AddAllResponses(const chip::Inet::IPPacketInfo * source, Res
void IPv6Responder::AddAllResponses(const chip::Inet::IPPacketInfo * source, ResponderDelegate * delegate,
const ResponseConfiguration & configuration)
{
if (!delegate->Accept(*this))
if (!delegate->ShouldSend(*this))
{
return;
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/dnssd/minimal_mdns/responders/Ptr.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class PtrResponder : public RecordResponder
void AddAllResponses(const chip::Inet::IPPacketInfo * source, ResponderDelegate * delegate,
const ResponseConfiguration & configuration) override
{
if (!delegate->Accept(*this))
if (!delegate->ShouldSend(*this))
{
return;
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/dnssd/minimal_mdns/responders/QueryResponder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ void QueryResponderBase::MarkAdditionalRepliesFor(QueryResponderIterator it)
void QueryResponderBase::AddAllResponses(const chip::Inet::IPPacketInfo * source, ResponderDelegate * delegate,
const ResponseConfiguration & configuration)
{
if (!delegate->Accept(*this))
if (!delegate->ShouldSend(*this))
{
return;
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/dnssd/minimal_mdns/responders/Responder.h
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class ResponderDelegate
/// Accept to add responses for the particular responder.
///
/// This will be called before responders serialize their records.
virtual bool Accept(const Responder &) const { return true; }
virtual bool ShouldSend(const Responder &) const { return true; }

/// Called when all responses were added for a particular responder
///
Expand Down
2 changes: 1 addition & 1 deletion src/lib/dnssd/minimal_mdns/responders/Srv.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class SrvResponder : public RecordResponder
void AddAllResponses(const chip::Inet::IPPacketInfo * source, ResponderDelegate * delegate,
const ResponseConfiguration & configuration) override
{
if (!delegate->Accept(*this))
if (!delegate->ShouldSend(*this))
{
return;
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/dnssd/minimal_mdns/responders/Txt.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class TxtResponder : public RecordResponder
void AddAllResponses(const chip::Inet::IPPacketInfo * source, ResponderDelegate * delegate,
const ResponseConfiguration & configuration) override
{
if (!delegate->Accept(*this))
if (!delegate->ShouldSend(*this))
{
return;
}
Expand Down

0 comments on commit 3365912

Please sign in to comment.