Merge branch 'master' into make-startup-temp-nullable

.github/workflows/build.yaml

@@ -377,6 +377,9 @@ jobs:
                   scripts/run_in_build_env.sh "ninja -C ./out/$BUILD_TYPE"
             - name: Setup Build, Run Build and Run Tests
               timeout-minutes: 120
+              # We can't enable leak checking here in LSAN_OPTIONS, because on
+              # Darwin that's only supported with a new enough clang, and we're
+              # not building with the pigweed clang here.
               run: |
                   for BUILD_TYPE in default python_lib; do
                       case $BUILD_TYPE in

.github/workflows/cherry-picks.yaml

@@ -14,6 +14,9 @@ jobs:
             (github.event.pull_request.merged == true)
             && (
                    (contains(github.event.pull_request.labels.*.name, 'sve'))
+               ||  (contains(github.event.pull_request.labels.*.name, 'spec'))
+               ||  (contains(github.event.pull_request.labels.*.name, 'request sve'))
+               ||  (contains(github.event.pull_request.labels.*.name, 'cert blocker'))
             )
         steps:
             - name: Checkout
@@ -24,7 +27,7 @@ jobs:
               uses: carloscastrojumo/github-cherry-pick-action@v1.0.1
               with:
                   token: ${{ secrets.MATTER_PAT }}
-                  branch: sve
+                  branch: sve-2
                   labels: |
                       sve cherry pick
                   reviewers: |

.github/workflows/darwin-tests.yaml

@@ -32,9 +32,10 @@ jobs:
 
         strategy:
             matrix:
-                build_variant: [no-ble-asan]
+                build_variant: [no-ble-asan-clang]
         env:
             BUILD_VARIANT: ${{matrix.build_variant}}
+            LSAN_OPTIONS: detect_leaks=1 malloc_context_size=40 suppressions=scripts/tests/chiptest/lsan-mac-suppressions.txt
 
         if: github.actor != 'restyled-io[bot]'
         runs-on: macos-latest

.github/workflows/docker_img.yaml

@@ -42,7 +42,12 @@ jobs:
                     - "-esp32"
                     - "-esp32-qemu"
                     - "-infineon"
-                    - "-imx"
+                    # NOTE: imx image requires too much space for GitHub-hosted runners. It fails with:
+                    # ```
+                    # ....
+                    # ApplyLayer exit status 1 stdout:  stderr: write /opt/fsl-imx-xwayland/5.15-kirkstone/sysroots/armv8a-poky-linux/opt/ltp/testcases/bin/fanotify15: no space left on device
+                    # ```
+                    # - "-imx"
                     - "-k32w"
                     - "-mbed-os"
                     - "-nrf-platform"

.github/workflows/examples-efr32.yaml

@@ -48,7 +48,7 @@ jobs:
           attempt_limit: 3
           attempt_delay: 2000
       - name: Checkout submodules
-        run: scripts/checkout_submodules.py --shallow --platform efr32
+        run: scripts/checkout_submodules.py --shallow --recursive --platform efr32
 
       # - name: Out of Tree verification
       #   run: third_party/silabs/out_of_tree_verification.sh
@@ -94,8 +94,8 @@ jobs:
       - name: Build example EFR32 Lighting App for BRD4161A with RPCs
         timeout-minutes: 15
         run: |
-          scripts/examples/gn_efr32_example.sh examples/lighting-app/efr32/ out/lighting_app_debug_rpc BRD4161A \
-            'import("//with_pw_rpc.gni")'
+          scripts/examples/gn_efr32_example.sh examples/lighting-app/efr32/ out/lighting_app_debug_rpc BRD4161A "is_debug=false" \
+            disable_lcd=true 'import("//with_pw_rpc.gni")'
           .environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py efr32 BRD4161A+rpc lighting-app \
             out/lighting_app_debug_rpc/BRD4161A/chip-efr32-lighting-example.out /tmp/bloat_reports/
       - name: Build example EFR32+WF200 WiFi Lock app for BRD4161A

.github/workflows/examples-esp32.yaml

@@ -23,7 +23,6 @@ concurrency:
     cancel-in-progress: true
 
 jobs:
-    # TODO ESP32 https://github.com/project-chip/connectedhomeip/issues/1510
     esp32:
         name: ESP32
         timeout-minutes: 120

.github/workflows/examples-infineon.yaml

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-name: Build example - Infineon P6
+name: Build example - Infineon
 
 on:
     push:
@@ -33,7 +33,8 @@ jobs:
 
         container:
             image: connectedhomeip/chip-build-infineon:0.5.91
-
+            volumes:
+                - "/tmp/bloat_reports:/tmp/bloat_reports"
         steps:
             - uses: Wandalen/wretry.action@v1.0.15
               name: Checkout
@@ -44,7 +45,7 @@ jobs:
                   attempt_limit: 3
                   attempt_delay: 2000
             - name: Checkout submodules
-              run: scripts/checkout_submodules.py --shallow --platform p6
+              run: scripts/checkout_submodules.py --shallow --platform infineon
 
             - name: Set up environment for size reports
               if: ${{ !env.ACT }}
@@ -63,65 +64,97 @@ jobs:
                   path: |
                       .environment/gn_out/.ninja_log
                       .environment/pigweed-venv/*.log
-            - name: Build lock-app example
+            - name: Build PSoC6 lock-app example
               timeout-minutes: 15
               run: |
                   scripts/run_in_build_env.sh \
                     "scripts/build/build_examples.py \
                         --enable-flashbundle --no-log-timestamps \
-                        --target infineon-p6-lock \
+                        --target infineon-psoc6-lock \
                         build \
                         --copy-artifacts-to out/artifacts \
                     "
                   .environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
-                      p6 default lock-app \
-                      out/infineon-p6-lock/chip-p6-lock-example.out
-            - name: Build all-clusters-app example
+                      psoc6 cy8ckit_062s2_43012 lock \
+                      out/artifacts/infineon-psoc6-lock/chip-psoc6-lock-example.out \
+                      /tmp/bloat_reports/
+            - name: Build PSoC6 all-clusters-app example
               timeout-minutes: 20
               run: |
                   scripts/run_in_build_env.sh \
                     "scripts/build/build_examples.py \
                         --enable-flashbundle --no-log-timestamps \
-                        --target infineon-p6-all-clusters \
+                        --target infineon-psoc6-all-clusters \
                         build \
                         --copy-artifacts-to out/artifacts \
                     "
                   .environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
-                      p6 default all-clusters-app \
-                      out/infineon-p6-all-clusters/chip-p6-clusters-example.out
-            - name: Build all-clusters-minimal-app example
+                      psoc6 cy8ckit_062s2_43012 all-clusters \
+                      out/artifacts/infineon-psoc6-all-clusters/chip-psoc6-clusters-example.out \
+                      /tmp/bloat_reports/
+            - name: Build PSoC6 all-clusters-minimal-app example
               timeout-minutes: 20
               run: |
                   scripts/run_in_build_env.sh \
                     "scripts/build/build_examples.py \
                         --enable-flashbundle --no-log-timestamps \
-                        --target infineon-p6-all-clusters-minimal \
+                        --target infineon-psoc6-all-clusters-minimal \
                         build \
                         --copy-artifacts-to out/artifacts \
                     "
                   .environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
-                      p6 default all-clusters-minimal-app \
-                      out/infineon-p6-all-clusters-minimal/chip-p6-clusters-minimal-example.out
-            - name: Build lighting-app example
+                      psoc6 cy8ckit_062s2_43012 all-clusters-minimal \
+                      out/artifacts/infineon-psoc6-all-clusters-minimal/chip-psoc6-clusters-minimal-example.out \
+                      /tmp/bloat_reports/
+            - name: Build PSoC6 lighting-app example
               timeout-minutes: 15
               run: |
                   scripts/run_in_build_env.sh \
                     "scripts/build/build_examples.py \
                         --enable-flashbundle --no-log-timestamps \
-                        --target infineon-p6-light \
+                        --target infineon-psoc6-light \
                         build \
                         --copy-artifacts-to out/artifacts \
                     "
                   .environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
-                      p6 default light-app \
-                      out/infineon-p6-light/chip-p6-lighting-example.out
+                      psoc6 cy8ckit_062s2_43012 light \
+                      out/artifacts/infineon-psoc6-light/chip-psoc6-lighting-example.out \
+                      /tmp/bloat_reports/
+
+            - name: Build example CYW30739 Apps
+              timeout-minutes: 30
+              run: |
+                  ./scripts/run_in_build_env.sh \
+                    "./scripts/build/build_examples.py \
+                      --target-glob 'cyw30739-cyw930739m2evb_01-{light,lock,ota-requestor-no-progress-logging}' \
+                      build \
+                      --copy-artifacts-to out/artifacts \
+                    "
+            - name: Get light size stats
+              timeout-minutes: 5
+              run: |
+                  .environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
+                    cyw30739 cyw930739m2evb_01 light \
+                    out/artifacts/cyw30739-cyw930739m2evb_01-light/chip-cyw30739-lighting-example.elf \
+                    /tmp/bloat_reports/
+            - name: Get lock size stats
+              timeout-minutes: 5
+              run: |
+                  .environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
+                    cyw30739 cyw930739m2evb_01 lock \
+                    out/artifacts/cyw30739-cyw930739m2evb_01-lock/chip-cyw30739-lock-example.elf \
+                    /tmp/bloat_reports/
+            - name: Get ota-requestor size stats
+              timeout-minutes: 5
+              run: |
+                  .environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
+                    cyw30739 cyw930739m2evb_01 ota-requestor-no-progress-logging \
+                    out/artifacts/cyw30739-cyw930739m2evb_01-ota-requestor-no-progress-logging/chip-cyw30739-ota-requestor-example.elf \
+                    /tmp/bloat_reports/
             - name: Uploading Size Reports
               uses: actions/upload-artifact@v2
               if: ${{ !env.ACT }}
               with:
-                  name: Size,P6-Examples,${{ env.GH_EVENT_PR }},${{ env.GH_EVENT_HASH }},${{ env.GH_EVENT_PARENT }},${{ github.event_name }}
+                  name: Size,Infineon-Examples,${{ env.GH_EVENT_PR }},${{ env.GH_EVENT_HASH }},${{ env.GH_EVENT_PARENT }},${{ github.event_name }}
                   path: |
-                      out/infineon-p6-lock/p6-default-lock-app-sizes.json
-                      out/infineon-p6-all-clusters/p6-default-all-clusters-app-sizes.json
-                      out/infineon-p6-all-clusters-minimal/p6-default-all-clusters-minimal-app-sizes.json
-                      out/infineon-p6-light/p6-default-light-app-sizes.json
+                      /tmp/bloat_reports/