Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max serial number length and firmware revision length are hardcoded #106

Closed
pan-apple opened this issue Mar 24, 2020 · 2 comments
Closed
Labels
feature work p1 priority 1 work stale Stale issue or PR
Milestone

Comments

@pan-apple
Copy link
Contributor

Problem

#104 hardcoded the lengths to 32 bytes. This was done as ChipDeviceDescriptor is not implemented yet.

https://github.com/project-chip/connectedhomeip/blob/master/src/include/platform/ConfigurationManager.h#L62

Proposed Solution

Once a device descriptor is implemented, read these two values from its configuration.

@pan-apple pan-apple changed the title Max serial number length and firmware revision length is hardcoded Max serial number length and firmware revision length are hardcoded Mar 24, 2020
@rwalker-apple rwalker-apple added this to the M4 milestone Mar 25, 2020
@woody-apple woody-apple modified the milestones: Not sure when, V1.0 May 26, 2020
@woody-apple woody-apple added the p1 priority 1 work label Oct 16, 2020
@stale
Copy link

stale bot commented Oct 16, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Oct 16, 2021
@stale
Copy link

stale bot commented Oct 23, 2021

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature work p1 priority 1 work stale Stale issue or PR
Projects
None yet
Development

No branches or pull requests

3 participants