Fixes for building nRF5 platform #104

pan-apple · 2020-03-24T20:28:22Z

Problem

Code for nRF5 platform is not getting built.

Summary of Changes

Imported missing code
Removed dependency on Profiles
Fix code, and makefiles
Some code is heavily dependent on Profiles and other code that we are not importing. So that is still not being built (ConfigurationManager, ThreadStackManager, SoftwareUpdateManager)
Some code has been removed because of dependency on Profiles. Need to analyze that code, and bring it back with new framework.

ToDo: File issues for 4, and 5 above.

fixes #80

pan-apple · 2020-03-24T20:29:02Z

FYI @sagar-apple

woody-apple · 2020-03-24T20:29:15Z

src/include/platform/internal/GenericConfigurationManagerImpl.h

@@ -131,7 +130,7 @@ class GenericConfigurationManagerImpl

    ImplClass * Impl() { return static_cast<ImplClass *>(this); }

-    static void HashLengthAndBase64Value(Platform::Security::SHA256 & hash, const uint8_t * val, uint16_t valLen);
+    // static void HashLengthAndBase64Value(Platform::Security::SHA256 & hash, const uint8_t * val, uint16_t valLen);


Can we delete, and not comment?

woody-apple · 2020-03-24T20:29:38Z

src/include/platform/internal/GenericConfigurationManagerImpl.ipp

 template<class ImplClass>
 CHIP_ERROR GenericConfigurationManagerImpl<ImplClass>::_GetQRCodeString(char * buf, size_t bufSize)
 {
+    return CHIP_ERROR_NOT_IMPLEMENTED;
+/*  Commented out for time being, until we have Device Description service


Can we delete then?

gerickson · 2020-03-24T20:32:20Z

src/include/platform/ConfigurationManager.h

 public:

    // ===== Members that define the public interface of the ConfigurationManager

    enum
    {
        kMaxPairingCodeLength = 15,
-        kMaxSerialNumberLength = ChipDeviceDescriptor::kMaxSerialNumberLength,
-        kMaxFirmwareRevisionLength = ChipDeviceDescriptor::kMaxSoftwareVersionLength,
+        kMaxSerialNumberLength = 32,


Tag these with an XXX or some such for follow-up?

ToDo: File issue to track this

gerickson · 2020-03-24T20:32:28Z

src/include/platform/ConfigurationManager.h

-        kMaxSerialNumberLength = ChipDeviceDescriptor::kMaxSerialNumberLength,
-        kMaxFirmwareRevisionLength = ChipDeviceDescriptor::kMaxSoftwareVersionLength,
+        kMaxSerialNumberLength = 32,
+        kMaxFirmwareRevisionLength = 32,


Tag these with an XXX or some such for follow-up?

@gerickson I am going to submit GitHub issues to track these.

pan-apple · 2020-03-24T20:30:00Z

src/include/platform/CHIPDeviceConfig.h

@@ -403,7 +403,7 @@
 * using the chip Time Sync protocol.
 */
 #ifndef CHIP_DEVICE_CONFIG_ENABLE_CHIP_TIME_SERVICE_TIME_SYNC
-#define CHIP_DEVICE_CONFIG_ENABLE_CHIP_TIME_SERVICE_TIME_SYNC 1
+#define CHIP_DEVICE_CONFIG_ENABLE_CHIP_TIME_SERVICE_TIME_SYNC 0


ToDo: File issue to track this

pan-apple · 2020-03-24T20:30:18Z

src/include/platform/ConfigurationManager.h

@@ -429,16 +417,6 @@ inline CHIP_ERROR ConfigurationManager::WritePersistedStorageValue(::chip::Platf
    return static_cast<ImplClass*>(this)->_WritePersistedStorageValue(key, value);
 }

-inline CHIP_ERROR ConfigurationManager::GetDeviceDescriptor(chipDeviceDescriptor & deviceDesc)


ToDo: File issue to track this

pan-apple · 2020-03-24T20:31:03Z

src/include/platform/internal/GenericConfigurationManagerImpl.ipp

@@ -704,96 +701,11 @@ CHIP_ERROR GenericConfigurationManagerImpl<ImplClass>::_SetFailSafeArmed(bool va
    return Impl()->WriteConfigValue(ImplClass::kConfigKey_FailSafeArmed, val);
 }

-template<class ImplClass>
-CHIP_ERROR GenericConfigurationManagerImpl<ImplClass>::_GetDeviceDescriptor(::chip::Profiles::DeviceDescription::ChipDeviceDescriptor & deviceDesc)


ToDo: File issue to track this

pan-apple · 2020-03-24T20:31:20Z

src/include/platform/internal/GenericConfigurationManagerImpl.ipp

 template<class ImplClass>
 CHIP_ERROR GenericConfigurationManagerImpl<ImplClass>::_GetQRCodeString(char * buf, size_t bufSize)
 {
+    return CHIP_ERROR_NOT_IMPLEMENTED;
+/*  Commented out for time being, until we have Device Description service


ToDo: File issue to track this

pan-apple · 2020-03-24T20:31:29Z

src/include/platform/internal/GenericConfigurationManagerImpl.ipp

@@ -969,7 +882,7 @@ CHIP_ERROR GenericConfigurationManagerImpl<ImplClass>::_ComputeProvisioningHash(
        SuccessOrExit(err);

        // Hash the length and value of the device certificate in base-64 form.
-        HashLengthAndBase64Value(hash, dataBuf, (uint16_t)certLen);
+        // HashLengthAndBase64Value(hash, dataBuf, (uint16_t)certLen);


ToDo: File issue to track this

pan-apple · 2020-03-24T20:33:09Z

src/include/platform/internal/GenericSoftwareUpdateManagerImpl.ipp

-    mExchangeCtx->OnKeyError        = OnKeyError;
-
-    // Send the query
-    err =  mExchangeCtx->SendMessage(kChipProfile_SWU,


ToDo: File issue to track this

pan-apple · 2020-03-24T20:33:26Z

src/include/platform/internal/GenericSoftwareUpdateManagerImpl.ipp

-void GenericSoftwareUpdateManagerImpl<ImplClass>::HandleResponse(ExchangeContext * ec, const IPPacketInfo * pktInfo, const ChipMessageInfo * msgInfo,
-                                                                 uint32_t profileId, uint8_t msgType, PacketBuffer * payload)
-{
-    GenericSoftwareUpdateManagerImpl<ImplClass> * self = &SoftwareUpdateMgrImpl();


ToDo: File issue to track this

pan-apple · 2020-03-24T20:33:33Z

src/include/platform/internal/GenericSoftwareUpdateManagerImpl.ipp

-void GenericSoftwareUpdateManagerImpl<ImplClass>::HandleServiceBindingEvent(void * appState, ::chip::Binding::EventType eventType,
-    const ::chip::Binding::InEventParam & aInParam, ::chip::Binding::OutEventParam & aOutParam)
-{
-    CHIP_ERROR err = CHIP_NO_ERROR;


ToDo: File issue to track this

pan-apple · 2020-03-24T20:33:47Z

src/include/platform/nRF5/CHIPDevicePlatformConfig.h

@@ -40,7 +40,7 @@

 #define CHIP_DEVICE_CONFIG_ENABLE_CHIPOBLE 1

-#define CHIP_DEVICE_CONFIG_ENABLE_CHIP_TIME_SERVICE_TIME_SYNC 1


ToDo: File issue to track this

pan-apple · 2020-03-24T20:35:09Z

src/include/platform/ConfigurationManager.h

 public:

    // ===== Members that define the public interface of the ConfigurationManager

    enum
    {
        kMaxPairingCodeLength = 15,
-        kMaxSerialNumberLength = ChipDeviceDescriptor::kMaxSerialNumberLength,
-        kMaxFirmwareRevisionLength = ChipDeviceDescriptor::kMaxSoftwareVersionLength,
+        kMaxSerialNumberLength = 32,


ToDo: File issue to track this

gerickson

There's a sufficiently large amount of commented out / changed code in here that I'd recommend determining a "breadcrumb" convention such that you / we know that we need to come back and revisit those breadcrumbs for those comment outs / changes.

pan-apple · 2020-03-24T20:57:07Z

There's a sufficiently large amount of commented out / changed code in here that I'd recommend determining a "breadcrumb" convention such that you / we know that we need to come back and revisit those breadcrumbs for those comment outs / changes.

@gerickson I was thinking of filing Github issues. But I am open to following breadcrumbs. LMK whatever works best overall. Github issues have benefit that it can be tracked, without grepp'ing through the code.

woody-apple · 2020-03-24T23:02:22Z

@hawk248 @BroderickCarlin ?

hawk248

👍

Fixes: project-chip#104

pan-apple added 5 commits March 24, 2020 13:23

Import VendorIdentifiers

0df92e8

Fix namespace for vendor identifiers

c651f29

Import Key IDs

250a97a

Fix namespace for ChipKeyIDs

a30f563

Fixes for building nRF5 platform code

e26cd7a

pan-apple requested review from anush-apple, BroderickCarlin, chrisdecenzo, gerickson, hawk248, robszewczyk, tpmanley and woody-apple as code owners March 24, 2020 20:28

woody-apple requested changes Mar 24, 2020

View reviewed changes

gerickson reviewed Mar 24, 2020

View reviewed changes

pan-apple commented Mar 24, 2020

View reviewed changes

gerickson suggested changes Mar 24, 2020

View reviewed changes

Remove commented out code

b9b31bc

pan-apple mentioned this pull request Mar 24, 2020

Reenable TIME_SERVICE_TIME_SYNC #105

Closed

woody-apple approved these changes Mar 24, 2020

View reviewed changes

This was referenced Mar 25, 2020

BLE Device name is hardcoded #112

Closed

nRF5 platform makefile is not building all source code #113

Closed

pan-apple requested a review from gerickson March 25, 2020 01:06

gerickson approved these changes Mar 25, 2020

View reviewed changes

hawk248 approved these changes Mar 25, 2020

View reviewed changes

woody-apple merged commit 502fb51 into project-chip:master Mar 25, 2020

pan-apple deleted the nrf5-platform branch March 25, 2020 21:44

fkjagodzinski added a commit to fkjagodzinski/connectedhomeip that referenced this pull request Apr 8, 2021

Mbed: lock-app: Add ZCL updates for lock/unlock

942c3c7

Fixes: project-chip#104

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes for building nRF5 platform #104

Fixes for building nRF5 platform #104

pan-apple commented Mar 24, 2020

pan-apple commented Mar 24, 2020

woody-apple Mar 24, 2020

pan-apple Mar 24, 2020

woody-apple Mar 24, 2020

pan-apple Mar 24, 2020

gerickson Mar 24, 2020

pan-apple Mar 24, 2020

gerickson Mar 24, 2020

pan-apple Mar 24, 2020

pan-apple Mar 24, 2020

pan-apple Mar 24, 2020

pan-apple Mar 24, 2020

pan-apple Mar 24, 2020

pan-apple Mar 24, 2020

pan-apple Mar 24, 2020

pan-apple Mar 24, 2020

pan-apple Mar 24, 2020

pan-apple Mar 24, 2020

pan-apple Mar 24, 2020

gerickson left a comment

pan-apple commented Mar 24, 2020

woody-apple commented Mar 24, 2020

hawk248 left a comment

		@@ -40,7 +40,7 @@

		#define CHIP_DEVICE_CONFIG_ENABLE_CHIPOBLE 1

		#define CHIP_DEVICE_CONFIG_ENABLE_CHIP_TIME_SERVICE_TIME_SYNC 1

Fixes for building nRF5 platform #104

Fixes for building nRF5 platform #104

Conversation

pan-apple commented Mar 24, 2020

Problem

Summary of Changes

pan-apple commented Mar 24, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gerickson left a comment

Choose a reason for hiding this comment

pan-apple commented Mar 24, 2020

woody-apple commented Mar 24, 2020

hawk248 left a comment

Choose a reason for hiding this comment