Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge-functionality - The keypress is aborting the DUT #21212

Closed
sowmyassp opened this issue Jul 26, 2022 · 3 comments · Fixed by #21230
Closed

Bridge-functionality - The keypress is aborting the DUT #21212

sowmyassp opened this issue Jul 26, 2022 · 3 comments · Fixed by #21230
Assignees

Comments

@sowmyassp
Copy link

sowmyassp commented Jul 26, 2022

Issue :
We have test-steps saying to press 'c' to read the state in bridge-app and press 'b' in bridge-app to change the light which are aborting the DUT
image

  • Commit used : 2987329
  • Chip-tool - RPI-4, 8GB RAM
  • DUT - RPI - RPI-4, 8GB RAM
  • Platform : linux platform
  • Dut application: bridge-app

Test-plan reference
https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/bridge.adoc#ref_TC-BR-4

@sowmyassp sowmyassp changed the title TC-BR-4 - The keypress is aborting the DUT Bridge-functionality - The keypress is aborting the DUT Jul 26, 2022
@bzbarsky-apple bzbarsky-apple self-assigned this Jul 26, 2022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jul 26, 2022
…dge-app.

A few changes here:

1. Stop trying to pass values to the attribute change callback, since those get
   ignored anyway.
2. Run the attribute change callback off a task on the Matter thread, instead of
   calling it directly from a different thread.
3. Change initial bridge setup to set state before setting change callbacks, so
   we won't try to notify changes at startup before the Matter stack is actually
   initialized.

Fixes project-chip#21212
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jul 26, 2022
…dge-app.

A few changes here:

1. Stop trying to pass values to the attribute change callback, since those get
   ignored anyway.
2. Run the attribute change callback off a task on the Matter thread, instead of
   calling it directly from a different thread.
3. Change initial bridge setup to set state before setting change callbacks, so
   we won't try to notify changes at startup before the Matter stack is actually
   initialized.

Fixes project-chip#21212
woody-apple pushed a commit that referenced this issue Jul 27, 2022
…dge-app. (#21230)

A few changes here:

1. Stop trying to pass values to the attribute change callback, since those get
   ignored anyway.
2. Run the attribute change callback off a task on the Matter thread, instead of
   calling it directly from a different thread.
3. Change initial bridge setup to set state before setting change callbacks, so
   we won't try to notify changes at startup before the Matter stack is actually
   initialized.

Fixes #21212
github-actions bot pushed a commit that referenced this issue Jul 27, 2022
…dge-app. (#21230)

A few changes here:

1. Stop trying to pass values to the attribute change callback, since those get
   ignored anyway.
2. Run the attribute change callback off a task on the Matter thread, instead of
   calling it directly from a different thread.
3. Change initial bridge setup to set state before setting change callbacks, so
   we won't try to notify changes at startup before the Matter stack is actually
   initialized.

Fixes #21212
woody-apple added a commit that referenced this issue Jul 28, 2022
…dge-app. (#21230) (#21309)

A few changes here:

1. Stop trying to pass values to the attribute change callback, since those get
   ignored anyway.
2. Run the attribute change callback off a task on the Matter thread, instead of
   calling it directly from a different thread.
3. Change initial bridge setup to set state before setting change callbacks, so
   we won't try to notify changes at startup before the Matter stack is actually
   initialized.

Fixes #21212

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@sowmyassp
Copy link
Author

The Keypress 2 and 4 is also aborting DUT
image

@bzbarsky-apple
Copy link
Contributor

@sowmyassp #21287 should fix those on Linux. On Mac some more work will be needed to make it work....

@sowmyassp
Copy link
Author

sowmyassp commented Jul 29, 2022

@bzbarsky-apple I am working it on Linux itself, but its aborting in linux too

isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this issue Sep 16, 2022
…dge-app. (project-chip#21230)

A few changes here:

1. Stop trying to pass values to the attribute change callback, since those get
   ignored anyway.
2. Run the attribute change callback off a task on the Matter thread, instead of
   calling it directly from a different thread.
3. Change initial bridge setup to set state before setting change callbacks, so
   we won't try to notify changes at startup before the Matter stack is actually
   initialized.

Fixes project-chip#21212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants