Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TC-DL use invalid PICS code #22248

Closed
tcarmelveilleux opened this issue Aug 29, 2022 · 0 comments · Fixed by #22249
Closed

TC-DL use invalid PICS code #22248

tcarmelveilleux opened this issue Aug 29, 2022 · 0 comments · Fixed by #22249
Assignees
@tcarmelveilleux
Labels
cert spec Mismatch between spec and implementation sve V1.0

Comments

@tcarmelveilleux
Copy link
Contributor

Problem

As raised in https://github.com/CHIP-Specifications/chip-test-plans/issues/2109, SDK uses some invalid PICS code for feature bits 10 and 11 of DoorLock cluster.

Instead of DRLK.S.F0a/F0b, we have DRLK.S.F10/F11, which is broken.

Proposed Solution

  • Update the PICS to reflect the correct nomenclature used for all PICS
@tcarmelveilleux tcarmelveilleux added V1.0 spec Mismatch between spec and implementation cert sve labels Aug 29, 2022
@tcarmelveilleux tcarmelveilleux self-assigned this Aug 29, 2022
tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this issue Aug 29, 2022
@tcarmelveilleux
Update DRLK feature PICS to correct format
43818da 
- TC-DRLK-XX use wrong values for two pics (see project-chip#22248)

This PR renames the PICS and also properly implement TC-DRLK-1.1
feature bits check to match test plan

Fixes project-chip#22248

Testing done:
- Tests in CI still pass after regen
@tcarmelveilleux tcarmelveilleux mentioned this issue Aug 29, 2022
Merged
tcarmelveilleux added a commit that referenced this issue Aug 30, 2022
@tcarmelveilleux
Update DRLK feature PICS to correct format (#22249)
9966613 
* Update DRLK feature PICS to correct format

- TC-DRLK-XX use wrong values for two pics (see #22248)

This PR renames the PICS and also properly implement TC-DRLK-1.1
feature bits check to match test plan

Fixes #22248

Testing done:
- Tests in CI still pass after regen

* Fix CI PICS values to match existing application
github-actions bot pushed a commit that referenced this issue Aug 30, 2022
@tcarmelveilleux @web-flow
Update DRLK feature PICS to correct format (#22249)
3ff5a11 
* Update DRLK feature PICS to correct format

- TC-DRLK-XX use wrong values for two pics (see #22248)

This PR renames the PICS and also properly implement TC-DRLK-1.1
feature bits check to match test plan

Fixes #22248

Testing done:
- Tests in CI still pass after regen

* Fix CI PICS values to match existing application
@woody-apple woody-apple mentioned this issue Aug 30, 2022
Merged
andy31415 pushed a commit that referenced this issue Aug 31, 2022
@woody-apple @tcarmelveilleux
Update DRLK feature PICS to correct format (#22249) (#22252)
f046787 
* Update DRLK feature PICS to correct format

- TC-DRLK-XX use wrong values for two pics (see #22248)

This PR renames the PICS and also properly implement TC-DRLK-1.1
feature bits check to match test plan

Fixes #22248

Testing done:
- Tests in CI still pass after regen

* Fix CI PICS values to match existing application

Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this issue Sep 16, 2022
@tcarmelveilleux @isiu-apple
Update DRLK feature PICS to correct format (project-chip#22249)
f9fb900 
* Update DRLK feature PICS to correct format

- TC-DRLK-XX use wrong values for two pics (see project-chip#22248)

This PR renames the PICS and also properly implement TC-DRLK-1.1
feature bits check to match test plan

Fixes project-chip#22248

Testing done:
- Tests in CI still pass after regen

* Fix CI PICS values to match existing application
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcarmelveilleux tcarmelveilleux

Labels
cert spec Mismatch between spec and implementation sve V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update DRLK feature PICS to correct format tcarmelveilleux/connectedhomeip
1 participant
@tcarmelveilleux