Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a private helper on SystemPacketBuffer to get a pointer to the start of the header space. #5372

Closed
bzbarsky-apple opened this issue Mar 15, 2021 · 2 comments · Fixed by #23284
Closed

Add a private helper on SystemPacketBuffer to get a pointer to the start of the header space. #5372

bzbarsky-apple opened this issue Mar 15, 2021 · 2 comments · Fixed by #23284
Labels
V1.X

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

We have lots of reinterpret_cast<uint8_t *>(someBuffer) + PacketBuffer::kStructureSize.

Proposed Solution

We should just have a helper for this.
@bzbarsky-apple bzbarsky-apple mentioned this issue Mar 15, 2021
Merged
@stale
Copy link

stale bot commented Jul 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jul 25, 2022
@stale
Copy link

stale bot commented Oct 18, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Oct 18, 2022
@stale stale bot removed the stale Stale issue or PR label Oct 20, 2022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 20, 2022
@bzbarsky-apple
Add a private method on SystemPacketBuffer to find where its reserved…
9bf1a79 
… space starts.

Fixes project-chip#5372
@bzbarsky-apple bzbarsky-apple mentioned this issue Oct 20, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 21, 2022
@bzbarsky-apple
Add a private method on SystemPacketBuffer to find where its reserved…
fcd372a 
… space starts.

Fixes project-chip#5372
bzbarsky-apple added a commit that referenced this issue Oct 25, 2022
@bzbarsky-apple
Add a private method on SystemPacketBuffer to find where its reserved…
0c2f7c6 
… space starts. (#23284)

Fixes #5372
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this issue Nov 18, 2022
@bzbarsky-apple @adbridge
Add a private method on SystemPacketBuffer to find where its reserved…
e5ac19e 
… space starts. (project-chip#23284)

Fixes project-chip#5372
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this issue Nov 18, 2022
@bzbarsky-apple @adbridge
Add a private method on SystemPacketBuffer to find where its reserved…
0fd55f7 
… space starts. (project-chip#23284)

Fixes project-chip#5372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
V1.X
Projects
None yet
Milestone
No milestone
2 participants
@woody-apple @bzbarsky-apple