Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failing #98

Closed
woody-apple opened this issue Mar 23, 2020 · 3 comments · Fixed by #99
Closed

Build failing #98

woody-apple opened this issue Mar 23, 2020 · 3 comments · Fixed by #99
Assignees
@gerickson @rwalker-apple
Milestone
May 1, 2020

Comments

@woody-apple
Copy link
Contributor

Problem

Build is failing here:

https://github.com/project-chip/connectedhomeip/runs/528993246?check_suite_focus=true

Assigning @gerickson & @rwalker-apple to talk about process, and the fix here :)
@gerickson
Copy link
Contributor

There ended up being two issues here:

  1. A simple set of typos in src/Makefile.am that specified MAYBE_PLATFORM_SUBDIRS in DIST_SUBDIRS (what gets packaged/distributed) which implies that src/platform only gets included by make dist when CONFIG_DEVICE_LAYER is in effect. This is not what's desired; src/platform should get placed in the distribution always. It should only be conditional in SUBDIRS (what gets built).
  2. A relative path problem for the headers in src/platform/Makefile.am in which they cannot / could not be located relative to that makefile in make dist.

@gerickson gerickson mentioned this issue Mar 24, 2020
Merged
@turon
Copy link
Contributor

turon commented Mar 24, 2020

See comment on #99 that simplifies the design pattern so bugs like (1) are less likely.

@gerickson
Copy link
Contributor

See comment on #99 that simplifies the design pattern so bugs like (1) are less likely.

We'll have to agree to disagree on this one. Anything qualified through a variable is flagged for "extra attention: conditional handling ahead!".

@rwalker-apple rwalker-apple added this to the M4 milestone Mar 24, 2020
fkjagodzinski added a commit to fkjagodzinski/connectedhomeip that referenced this issue Mar 18, 2021
@fkjagodzinski
Mbed: Add the BoltLockManager
e69d95f 
Fixes: project-chip#98
mkardous-silabs referenced this issue in SiliconLabs/watt-sandbox Oct 6, 2022
@silabsbot @mkardous-silabs
Pull request SiliconLabs#98: change chip build to use image tag 22
0632cc2 
Merge in WMN_TOOLS/matter from hotfix/dockertag to silabs

Squashed commit of the following:

commit 73190bf58b12ef3e7a3434c6b4d085a701c6ab5e
Author: Yulina Shu <Yulina.Shu@silabs.com>
Date:   Wed Sep 14 16:46:38 2022 +0000

    change chip build to use image tag 22
nipatel-silabs pushed a commit to nipatel-silabs/connectedhomeip that referenced this issue Oct 19, 2022
@silabsbot @jmartinez-silabs
Pull request project-chip#98: change chip build to use image tag 22
e62bbf1 
Merge in WMN_TOOLS/matter from hotfix/dockertag to silabs

Squashed commit of the following:

commit 73190bf58b12ef3e7a3434c6b4d085a701c6ab5e
Author: Yulina Shu <Yulina.Shu@silabs.com>
Date:   Wed Sep 14 16:46:38 2022 +0000

    change chip build to use image tag 22
mkardous-silabs referenced this issue in mkardous-silabs/connectedhomeip Oct 24, 2022
@silabsbot @jmartinez-silabs
Pull request #98: change chip build to use image tag 22
4a0b5a1 
Merge in WMN_TOOLS/matter from hotfix/dockertag to silabs

Squashed commit of the following:

commit 73190bf58b12ef3e7a3434c6b4d085a701c6ab5e
Author: Yulina Shu <Yulina.Shu@silabs.com>
Date:   Wed Sep 14 16:46:38 2022 +0000

    change chip build to use image tag 22
mkardous-silabs referenced this issue in mkardous-silabs/connectedhomeip Nov 2, 2022
@silabsbot @jmartinez-silabs
Pull request #98: change chip build to use image tag 22
6063af0 
Merge in WMN_TOOLS/matter from hotfix/dockertag to silabs

Squashed commit of the following:

commit 73190bf58b12ef3e7a3434c6b4d085a701c6ab5e
Author: Yulina Shu <Yulina.Shu@silabs.com>
Date:   Wed Sep 14 16:46:38 2022 +0000

    change chip build to use image tag 22
shgutte pushed a commit to shgutte/connectedhomeip that referenced this issue Oct 5, 2023
@silabsbot @jmartinez-silabs
Pull request project-chip#98: change chip build to use image tag 22
249e4c5 
Merge in WMN_TOOLS/matter from hotfix/dockertag to silabs

Squashed commit of the following:

commit 73190bf58b12ef3e7a3434c6b4d085a701c6ab5e
Author: Yulina Shu <Yulina.Shu@silabs.com>
Date:   Wed Sep 14 16:46:38 2022 +0000

    change chip build to use image tag 22
shgutte pushed a commit to shgutte/connectedhomeip that referenced this issue Jan 11, 2024
@silabsbot @jmartinez-silabs
Pull request project-chip#98: change chip build to use image tag 22
87dcd33 
Merge in WMN_TOOLS/matter from hotfix/dockertag to silabs

Squashed commit of the following:

commit 73190bf58b12ef3e7a3434c6b4d085a701c6ab5e
Author: Yulina Shu <Yulina.Shu@silabs.com>
Date:   Wed Sep 14 16:46:38 2022 +0000

    change chip build to use image tag 22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerickson gerickson

@rwalker-apple rwalker-apple

Labels
None yet
Projects
None yet
Milestone
May 1, 2020
Development

Successfully merging a pull request may close this issue.

Address GitHub Issue 98: 'make distcheck' Failure gerickson/connectedhomeip-private
4 participants
@turon @gerickson @woody-apple @rwalker-apple