Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Directed Commissioning: simplify shell commands #10364

Merged
merged 5 commits into from
Oct 28, 2021
Merged

User Directed Commissioning: simplify shell commands #10364

merged 5 commits into from
Oct 28, 2021

Conversation

chrisdecenzo
Copy link
Contributor

@chrisdecenzo chrisdecenzo commented Oct 8, 2021 •
edited
Loading

Problem

What is being fixed? Examples:

  • Shell commands for UDC are not user friendly

Change overview

  • Add device name, IP and port to UDC cache
  • Enable shell by default for tv-casting-app since it is required
  • Introduce shell commands to commission based upon entry in UDC cache:

controller udc-commission

ex.

controller udc-commission 34567890 0

Testing

  • Added to UDC unit tests for new cache fields
  • Tested using tv-app and tv-casting-app

@merge-mamba
Copy link

merge-mamba bot commented Oct 9, 2021 •
edited
Loading

Potential Conflict Warning

This pull request has changes that overlap with branches below. You might want to check in with the other
branch authors before you merge to avoid a conflict. 🐍

restyled/pull-9748 (@kghost @restyled-commits)

restyled/pull-10400 (@carol-apple @restyled-commits)

Something wrong? Got a suggestion? Email me or leave feedback here.

@woody-apple
Copy link
Contributor

@mrjerryjohns @saurabhst @andy31415 @Damian-Nordic @jelderton @jepenven-silabs @jmartinez-silabs ?

@stale
Copy link

stale bot commented Oct 22, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Oct 22, 2021
@woody-apple
Copy link
Contributor

@chrisdecenzo can you resolve build failures and conflicts? I can fast track this.

@stale stale bot removed the stale Stale issue or PR label Oct 22, 2021
@chrisdecenzo
Copy link
Contributor Author

@chrisdecenzo can you resolve build failures and conflicts? I can fast track this.

Yes, working on this today/tomorrow

@github-actions
Copy link

PR #10364: Size comparison from 5213452 to f37c72c

Increases (6 builds for linux)
platform target config section 5213452 f37c72c change % change
linux all-clusters-app debug .text 1358754 1358770 16 0.0
chip-tool debug .text 3651029 3651045 16 0.0
ota-provider-app debug .text 1025714 1025730 16 0.0
ota-requestor-app debug .text 1147666 1147682 16 0.0
shell debug .text 599458 599474 16 0.0
tv-app debug .rodata 151992 152664 672 0.4
.text 1456226 1458850 2624 0.2
Decreases (1 build for linux)
platform target config section 5213452 f37c72c change % change
linux tv-app debug .bss 215568 215536 -32 -0.0
Full report (8 builds for linux)
platform target config section 5213452 f37c72c change % change
linux all-clusters-app debug .bss 50160 50160 0 0.0
.data 978 978 0 0.0
.data.rel.ro 60800 60800 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 134613 134613 0 0.0
.text 1358754 1358770 16 0.0
chip-tool debug .bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 94640 94640 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 207988 207988 0 0.0
.text 3651029 3651045 16 0.0
ota-provider-app debug .bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110440 110440 0 0.0
.text 1025714 1025730 16 0.0
ota-requestor-app debug .bss 208320 208320 0 0.0
.data 752 752 0 0.0
.data.rel.ro 25928 25928 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 128936 128936 0 0.0
.text 1147666 1147682 16 0.0
shell debug .bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76495 76495 0 0.0
.text 599458 599474 16 0.0
tv-app debug .bss 215568 215536 -32 -0.0
.data 2032 2032 0 0.0
.data.rel.ro 58192 58192 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 151992 152664 672 0.4
.text 1456226 1458850 2624 0.2
bridge-app debug+rpc .bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109836 109836 0 0.0
.text 1066277 1066277 0 0.0
lighting-app debug+rpc .bss 41176 41176 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 53968 53968 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 126993 126993 0 0.0
.text 1264178 1264178 0 0.0

@woody-apple
Copy link
Contributor

/rebase

1 similar comment
@woody-apple
Copy link
Contributor

/rebase

@chrisdecenzo chrisdecenzo requested review from Byungjoo-Lee and removed request for shana-apple October 27, 2021 22:27
hawk248
hawk248 approved these changes Oct 27, 2021
View reviewed changes
Copy link

@hawk248 hawk248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@woody-apple woody-apple merged commit c747af9 into master Oct 28, 2021
@woody-apple woody-apple deleted the udc-shell branch October 28, 2021 00:20
JasonLiuZhuoCheng pushed a commit to JasonLiuZhuoCheng/connectedhomeip that referenced this pull request Oct 28, 2021
@chrisdecenzo @JasonLiuZhuoCheng
User Directed Commissioning: simplify shell commands (project-chip#10364
1330aa7 
)

* UDC: persist device name, IP and port in cache, simplify shell commands

* fix CI

* enable ip commissioning from tv-app

* address comment on shell command names
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@chrisdecenzo
User Directed Commissioning: simplify shell commands (project-chip#10364
cd56eef 
)

* UDC: persist device name, IP and port in cache, simplify shell commands

* fix CI

* enable ip commissioning from tv-app

* address comment on shell command names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharadb-amazon sharadb-amazon sharadb-amazon approved these changes

@hawk248 hawk248 hawk248 approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@wbschiller wbschiller Awaiting requested review from wbschiller

@chulspro chulspro Awaiting requested review from chulspro

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

Assignees
No one assigned
Labels
controller examples fast track lib review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chrisdecenzo @woody-apple @sharadb-amazon @hawk248