Fix CHIPClusters template for encoding CHAR_STRING. #11661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
lzgrablic02,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic and
vivien-apple
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
|
PR #11661: Size comparison from 9964cdb to b5faf6d Increases (1 build for esp32)
Decreases (1 build for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
erjiaqing
reviewed
Nov 11, 2021
|
/rebase |
woody-apple
force-pushed
the
fix-template
branch
from
b5faf6d
to
e026a18
Compare
|
PR #11661: Size comparison from d45cfaa to e026a18 Decreases (2 builds for esp32, linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
selissia
approved these changes
Nov 11, 2021
jmartinez-silabs
approved these changes
Nov 11, 2021
woody-apple
approved these changes
Nov 11, 2021
|
Fast tracking given trivial bug fix. |
woody-apple
approved these changes
Nov 11, 2021
|
/rebase |
We are grabbing the pointer from the Span and ignoring the length; we should just encode the Span as-is.
woody-apple
force-pushed
the
fix-template
branch
from
e026a18
to
74eff20
Compare
mrjerryjohns
approved these changes
Nov 11, 2021
|
PR #11661: Size comparison from aa7f89c to 74eff20 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
We are grabbing the pointer from the Span and ignoring the length; we should just encode the Span as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are grabbing the pointer from the Span and ignoring the length; we should just encode the Span
as-is.
Problem
Using a
const char *to represent a non-null-terminated string.Change overview
Stop doing that.
Testing
Examined the generated code. Unfortunately, our current YAML tests actually create spans from null-terminated strings, so don't catch this, and they don't use the API in question, which makes it particularly hard to use them to test for this problem.