-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement IM event buffer-pressure-based flushing #12781
Merged
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/event_buffer_full_delivery
Dec 16, 2021
Merged
Implement IM event buffer-pressure-based flushing #12781
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/event_buffer_full_delivery
Dec 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
lzgrablic02,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia and
tcarmelveilleux
December 9, 2021 07:38
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
December 9, 2021 07:38
yunhanw-google
force-pushed
the
feature/event_buffer_full_delivery
branch
from
December 9, 2021 07:39
9b4e239
to
4276d62
Compare
PR #12781: Size comparison from f18d8b7 to 4276d62 Increases (17 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
Decreases (6 builds for mbed, p6)
Full report (20 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/event_buffer_full_delivery
branch
from
December 9, 2021 09:00
4276d62
to
8141e81
Compare
PR #12781: Size comparison from f18d8b7 to 8141e81 Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (6 builds for mbed, p6)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/event_buffer_full_delivery
branch
from
December 16, 2021 00:27
8141e81
to
58b0c1e
Compare
pullapprove
bot
requested review from
Byungjoo-Lee,
chshu,
dhrishi,
gjc13 and
xylophone21
December 16, 2021 00:28
PR #12781: Size comparison from 00ec330 to 58b0c1e Increases (14 builds for efr32, k32w, linux, p6, qpg, telink)
Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/event_buffer_full_delivery
branch
from
December 16, 2021 01:16
58b0c1e
to
02d3260
Compare
PR #12781: Size comparison from 5988375 to 02d3260 Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
robszewczyk
approved these changes
Dec 16, 2021
gjc13
approved these changes
Dec 16, 2021
yunhanw-google
force-pushed
the
feature/event_buffer_full_delivery
branch
from
December 16, 2021 06:57
02d3260
to
c3f5f1a
Compare
PR #12781: Size comparison from 161cd14 to c3f5f1a Increases (14 builds for efr32, k32w, linux, p6, qpg, telink)
Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/event_buffer_full_delivery
branch
from
December 16, 2021 07:56
c3f5f1a
to
3becefa
Compare
PR #12781: Size comparison from 161cd14 to 3becefa Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the IM event buffers bytes number exceed the specified water mark, it would schedule event delivery.
Change overview
See above
Testing
Manually validated