Update ot-qorvo repo and remove some workarounds #13079

lucicop · 2021-12-16T12:41:37Z

Problem

OpenThread ot-qorvo repo was updated with files for new QPG6105 chip and references need to be updated

Change overview

update ot-qorvo references in third_party/openthread
removing some references to QPG6100 kept in place until ot-qorvo was updated

Testing

tested by compiling lighting application example and running TE7 scripting on the binary

into update_family

github-actions · 2021-12-16T13:21:35Z

PR #13079: Size comparison from be5e0f1 to 1f730c3

Full report (12 builds for efr32, k32w, linux, p6, telink)

platform	target	config	section	`be5e0f1`	`1f730c3`
efr32	lighting-app	BRD4161A	(read only)	829820	829820
			(read/write)	127348	127348
			.bss	125472	125472
			.data	1876	1876
			.text	829812	829812
		BRD4161A+rpc	(read only)	817440	817440
			(read/write)	144016	144016
			.bss	142040	142040
			.data	1976	1976
			.text	817432	817432
	window-app	BRD4161A	(read only)	803228	803228
			(read/write)	126288	126288
			.bss	124456	124456
			.data	1832	1832
			.text	803220	803220
k32w	lighting-app	k32w061+se05x+release	(read/write)	685500	685500
			.bss	78048	78048
			.data	1908	1908
			.text	599744	599744
	lock-app	k32w061+debug	(read/write)	633048	633048
			.bss	76200	76200
			.data	1860	1860
			.text	549188	549188
	shell	k32w061+debug	(read/write)	638640	638640
			.bss	78700	78700
			.data	1840	1840
			.text	552300	552300
linux	chip-tool-ipv6only	arm64	(read only)	6930700	6930700
			(read/write)	323633	323633
			.bss	54577	54577
			.data	1096	1096
			.data.rel.ro	208096	208096
			.dynamic	560	560
			.got	56160	56160
			.init	24	24
			.init_array	168	168
			.rodata	379476	379476
			.text	5863652	5863652
	thermostat-no-ble	arm64	(read only)	1993780	1993780
			(read/write)	143937	143937
			.bss	64321	64321
			.data	880	880
			.data.rel.ro	72000	72000
			.dynamic	560	560
			.got	3840	3840
			.init	24	24
			.init_array	288	288
			.rodata	128196	128196
			.text	1654112	1654112
p6	all-clusters-app	default	(read/write)	2384624	2384624
			.bss	117260	117260
			.data	2544	2544
			.text	1342888	1342888
	light-app	default	(read/write)	`2324008`	`2324008`
			.bss	106152	106152
			.data	2384	2384
			.text	1282272	1282272
	lock-app	default	(read/write)	`2296216`	`2296216`
			.bss	105032	105032
			.data	2336	2336
			.text	1254480	1254480
telink	lighting-app	tlsr9518adk80d	(read/write)	830222	830222
			bss	87040	87040
			noinit	37160	37160
			text	578410	578410

…omeip into update_family

github-actions · 2021-12-16T14:02:34Z

PR #13079: Size comparison from be5e0f1 to 8b99670

Increases above 0.2%:

platform	target	config	section	`be5e0f1`	`8b99670`	change	% change
esp32	all-clusters-app	c3devkit	.iram0.text	62076	62254	178	0.3

Increases (2 builds for esp32)

platform	target	config	section	`be5e0f1`	`8b99670`	change	% change
esp32	all-clusters-app	c3devkit	(read only)	875866	877064	1198	0.1
			.dram0.data	14204	14220	16	0.1
			.flash.text	875866	877064	1198	0.1
			.iram0.text	62076	62254	178	0.3
		m5stack	.dram0.bss	74264	74280	16	0.0
			.flash.rodata	202752	202800	48	0.0

Decreases (2 builds for esp32)

platform	target	config	section	`be5e0f1`	`8b99670`	change	% change
esp32	all-clusters-app	c3devkit	(read/write)	1313090	1313042	-48	-0.0
			.dram0.bss	69800	69784	-16	-0.0
			.flash.rodata	176024	175976	-48	-0.0
		m5stack	(read only)	938835	937939	-896	-0.1
			(read/write)	442580	442144	-436	-0.1
			.flash.text	933451	932555	-896	-0.1
			.iram0.text	123171	122671	-500	-0.4

Full report (29 builds for efr32, esp32, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`be5e0f1`	`8b99670`	change	% change
efr32	lighting-app	BRD4161A	(read only)	829820	829820	0	0.0
			(read/write)	127348	127348	0	0.0
			.bss	125472	125472	0	0.0
			.data	1876	1876	0	0.0
			.text	829812	829812	0	0.0
		BRD4161A+rpc	(read only)	817440	817440	0	0.0
			(read/write)	144016	144016	0	0.0
			.bss	142040	142040	0	0.0
			.data	1976	1976	0	0.0
			.text	817432	817432	0	0.0
	window-app	BRD4161A	(read only)	803228	803228	0	0.0
			(read/write)	126288	126288	0	0.0
			.bss	124456	124456	0	0.0
			.data	1832	1832	0	0.0
			.text	803220	803220	0	0.0
esp32	all-clusters-app	c3devkit	(read only)	875866	877064	1198	0.1
			(read/write)	1313090	1313042	-48	-0.0
			.dram0.bss	69800	69784	-16	-0.0
			.dram0.data	14204	14220	16	0.1
			.flash.rodata	176024	175976	-48	-0.0
			.flash.text	875866	877064	1198	0.1
			.iram0.text	62076	62254	178	0.3
		m5stack	(read only)	938835	937939	-896	-0.1
			(read/write)	442580	442144	-436	-0.1
			.dram0.bss	74264	74280	16	0.0
			.dram0.data	34056	34056	0	0.0
			.flash.rodata	202752	202800	48	0.0
			.flash.text	933451	932555	-896	-0.1
			.iram0.text	123171	122671	-500	-0.4
linux	chip-tool-ipv6only	arm64	(read only)	6930700	6930700	0	0.0
			(read/write)	323633	323633	0	0.0
			.bss	54577	54577	0	0.0
			.data	1096	1096	0	0.0
			.data.rel.ro	208096	208096	0	0.0
			.dynamic	560	560	0	0.0
			.got	56160	56160	0	0.0
			.init	24	24	0	0.0
			.init_array	168	168	0	0.0
			.rodata	379476	379476	0	0.0
			.text	5863652	5863652	0	0.0
	thermostat-no-ble	arm64	(read only)	1993780	1993780	0	0.0
			(read/write)	143937	143937	0	0.0
			.bss	64321	64321	0	0.0
			.data	880	880	0	0.0
			.data.rel.ro	72000	72000	0	0.0
			.dynamic	560	560	0	0.0
			.got	3840	3840	0	0.0
			.init	24	24	0	0.0
			.init_array	288	288	0	0.0
			.rodata	128196	128196	0	0.0
			.text	1654112	1654112	0	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2334040	2334040	0	0.0
			.bss	189068	189068	0	0.0
			.data	5264	5264	0	0.0
			.text	1296616	1296616	0	0.0
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2328616	2328616	0	0.0
			.bss	180896	180896	0	0.0
			.data	5544	5544	0	0.0
			.text	`1291216`	`1291216`	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2301648`	`2301648`	0	0.0
			.bss	179944	179944	0	0.0
			.data	5536	5536	0	0.0
			.text	1264248	1264248	0	0.0
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1140008	1140008	0	0.0
			.bss	11756	11756	0	0.0
			.data	4368	4368	0	0.0
			.text	103392	103392	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2053688	2053688	0	0.0
			.bss	156972	156972	0	0.0
			.data	4864	4864	0	0.0
			.text	1016288	1016288	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	935739	935739	0	0.0
			bss	118400	118400	0	0.0
			rodata	108056	108056	0	0.0
			text	631728	631728	0	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	922127	922127	0	0.0
			bss	115444	115444	0	0.0
			rodata	101476	101476	0	0.0
			text	627040	627040	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	859490	859490	0	0.0
			bss	116684	116684	0	0.0
			rodata	102984	102984	0	0.0
			text	559164	559164	0	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	907871	907871	0	0.0
			bss	117588	117588	0	0.0
			rodata	103364	103364	0	0.0
			text	609552	609552	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	831798	831798	0	0.0
			bss	115900	115900	0	0.0
			rodata	98324	98324	0	0.0
			text	537032	537032	0	0.0
	pigweed-app	nrf52840dk_nrf52840	(read/write)	542351	542351	0	0.0
			bss	52588	52588	0	0.0
			rodata	50668	50668	0	0.0
			text	376892	376892	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	912763	912763	0	0.0
			bss	117496	117496	0	0.0
			rodata	104704	104704	0	0.0
			text	613104	613104	0	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	905951	905951	0	0.0
			bss	117376	117376	0	0.0
			rodata	102836	102836	0	0.0
			text	608300	608300	0	0.0
	shell	nrf52840dk_nrf52840	(read/write)	796271	796271	0	0.0
			bss	109464	109464	0	0.0
			rodata	78032	78032	0	0.0
			text	532304	532304	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	708906	708906	0	0.0
			bss	107352	107352	0	0.0
			rodata	72336	72336	0	0.0
			text	449796	449796	0	0.0
p6	all-clusters-app	default	(read/write)	2384624	2384624	0	0.0
			.bss	117260	117260	0	0.0
			.data	2544	2544	0	0.0
			.text	1342888	1342888	0	0.0
	light-app	default	(read/write)	`2324008`	`2324008`	0	0.0
			.bss	106152	106152	0	0.0
			.data	2384	2384	0	0.0
			.text	1282272	1282272	0	0.0
	lock-app	default	(read/write)	`2296216`	`2296216`	0	0.0
			.bss	105032	105032	0	0.0
			.data	2336	2336	0	0.0
			.text	1254480	1254480	0	0.0
qpg	lighting-app	qpg6105+debug	(read only)	531904	531904	0	0.0
			(read/write)	146936	146936	0	0.0
			.bss	86816	86816	0	0.0
			.data	1004	1004	0	0.0
			.text	526584	526584	0	0.0
	lock-app	qpg6105+debug	(read only)	503600	503600	0	0.0
			(read/write)	146940	146940	0	0.0
			.bss	85952	85952	0	0.0
			.data	952	952	0	0.0
			.text	498280	498280	0	0.0
	persistent-storage-app	qpg6105+debug	(read only)	106448	106448	0	0.0
			(read/write)	146938	146938	0	0.0
			.bss	36146	36146	0	0.0
			.data	288	288	0	0.0
			.text	101128	101128	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	830222	830222	0	0.0
			bss	87040	87040	0	0.0
			noinit	37160	37160	0	0.0
			text	578410	578410	0	0.0

lucicop and others added 8 commits December 14, 2021 15:06

Replace QPG6100 by the new QPG6105

4e91517

Remove commented code

6f7f863

Adjusting chip name in builder scripts

b2d666d

Adjusting chip name in builder scripts - map naming

8179948

Correct formatting

55928a9

Add reference to updated ot-qorvo repo

89af144

Merge branch 'master' of https://github.com/project-chip/connectedhomeip

a94d6ee

into update_family

Merge branch 'project-chip:master' into update_family

1f730c3

boring-cyborg bot added examples platform labels Dec 16, 2021

pullapprove bot requested review from kghost, LuDuda, mlepage-google, mrjerryjohns, msandstedt, mspang, pan-apple, sagar-apple, saurabhst, selissia, tcarmelveilleux, tecimovic, turon, vijs, vivien-apple, wbschiller, woody-apple, xylophone21 and yunhanw-google December 16, 2021 12:41

pullapprove bot added the review - pending label Dec 16, 2021

lucicop added 2 commits December 16, 2021 14:36

Remove hardcoded target ic

e61f49f

Merge branch 'update_family' of https://github.com/lucicop/connectedh…

8b99670

…omeip into update_family

andy31415 approved these changes Dec 16, 2021

View reviewed changes

andy31415 added the fast track label Dec 16, 2021

andy31415 merged commit 4ca5d31 into project-chip:master Dec 16, 2021

lucicop deleted the update_family branch December 16, 2021 15:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update ot-qorvo repo and remove some workarounds #13079

Update ot-qorvo repo and remove some workarounds #13079

lucicop commented Dec 16, 2021

github-actions bot commented Dec 16, 2021 •

edited

Loading

github-actions bot commented Dec 16, 2021 •

edited

Loading

Update ot-qorvo repo and remove some workarounds #13079

Update ot-qorvo repo and remove some workarounds #13079

Conversation

lucicop commented Dec 16, 2021

Problem

Change overview

Testing

github-actions bot commented Dec 16, 2021 • edited Loading

github-actions bot commented Dec 16, 2021 • edited Loading

github-actions bot commented Dec 16, 2021 •

edited

Loading

github-actions bot commented Dec 16, 2021 •

edited

Loading