Fix reading attribute activeLocale failure #14255

yufengwangca · 2022-01-25T18:53:11Z

Problem

What is being fixed? Examples:

Always fails to read activeLocale in emberAfLocalizationConfigurationClusterServerInitCallback, the reason is we pass a null pointer with a zero-sized buffer to EmberAfStatus status = ActiveLocale::Get(endpoint, activeLocale)
Fix Not able to read the attribute with string type value #13771

Change overview

Fix reading attribute activeLocale failure

Testing

How was this tested? (at least one bullet point required)

During bootup, check the log and confirm no error message Failed to read ActiveLocale with error during initialization in the log.

src/app/clusters/localization-configuration-server/localization-configuration-server.cpp

…n-configuration-server.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

github-actions · 2022-01-25T19:43:36Z

PR #14255: Size comparison from 0902641 to 8c053c0

Increases (12 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)

platform	target	config	section	`0902641`	`8c053c0`	change
cyw30739	light	cyw930739m2evb_01	(read/write)	572258	572282	24
			.app_xip_area	477320	477344	24
efr32	window-app	BRD4161A	(read only)	808864	808880	16
			.text	808856	808872	16
esp32	all-clusters-app	c3devkit	(read only)	916980	917060	80
			.flash.text	916980	917060	80
		m5stack	(read only)	965955	965991	36
			.flash.text	960571	960607	36
k32w	light	k32w061+release	(read/write)	660496	660512	16
			.text	575372	575388	16
	lock	k32w061+release	(read/write)	661392	661408	16
			.text	575980	575996	16
linux	thermostat-no-ble	arm64	(read only)	2043436	2043452	16
			.text	`1698512`	`1698528`	16
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read/write)	2349912	2349976	64
			.text	1312512	`1312576`	64
p6	light-app	default	(read/write)	2327768	2327784	16
			.text	1286032	1286048	16
qpg	lighting-app	qpg6105+debug	(read only)	565568	565584	16
			.text	560248	560264	16
	lock-app	qpg6105+debug	(read only)	514324	514340	16
			.text	509004	509020	16
telink	lighting-app	tlsr9518adk80d	(read/write)	839534	839622	88
			text	586050	586136	86

Full report (22 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)

platform	target	config	section	`0902641`	`8c053c0`	change
cyw30739	light	cyw930739m2evb_01	(read/write)	572258	572282	24
			.app_xip_area	477320	477344	24
			.bss	77684	77684	0
			.data	596	596	0
			.rodata	0	0	0
			.text	0	0	0
efr32	lighting-app	BRD4161A	(read only)	832688	832688	0
			(read/write)	127216	127216	0
			.bss	125312	125312	0
			.data	1900	1900	0
			.text	832680	832680	0
		BRD4161A+rpc	(read only)	820068	820068	0
			(read/write)	143872	143872	0
			.bss	141872	141872	0
			.data	2000	2000	0
			.text	820060	820060	0
	window-app	BRD4161A	(read only)	808864	808880	16
			(read/write)	125872	125872	0
			.bss	124016	124016	0
			.data	1856	1856	0
			.text	808856	808872	16
esp32	all-clusters-app	c3devkit	(read only)	916980	917060	80
			(read/write)	1317858	1317858	0
			.dram0.bss	70696	70696	0
			.dram0.data	14244	14244	0
			.flash.rodata	179520	179520	0
			.flash.text	916980	917060	80
			.iram0.text	62056	62056	0
		m5stack	(read only)	965955	965991	36
			(read/write)	450432	450432	0
			.dram0.bss	75440	75440	0
			.dram0.data	34032	34032	0
			.flash.rodata	208832	208832	0
			.flash.text	960571	960607	36
			.iram0.text	123399	123399	0
k32w	light	k32w061+release	(read/write)	660496	660512	16
			.bss	77456	77456	0
			.data	1868	1868	0
			.text	575372	575388	16
	lock	k32w061+release	(read/write)	661392	661408	16
			.bss	77720	77720	0
			.data	1892	1892	0
			.text	575980	575996	16
linux	chip-tool-ipv6only	arm64	(read only)	`8697804`	`8697804`	0
			(read/write)	390817	390817	0
			.bss	56017	56017	0
			.data	1128	1128	0
			.data.rel.ro	260888	260888	0
			.dynamic	560	560	0
			.got	69040	69040	0
			.init	24	24	0
			.init_array	200	200	0
			.rodata	532532	532532	0
			.text	7326532	7326532	0
	thermostat-no-ble	arm64	(read only)	2043436	2043452	16
			(read/write)	146625	146625	0
			.bss	65649	65649	0
			.data	904	904	0
			.data.rel.ro	73072	73072	0
			.dynamic	560	560	0
			.got	4048	4048	0
			.init	24	24	0
			.init_array	320	320	0
			.rodata	130620	130620	0
			.text	`1698512`	`1698528`	16
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0
			(read/write)	2349912	2349976	64
			.bss	189404	189404	0
			.data	5296	5296	0
			.text	1312512	`1312576`	64
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0
			(read/write)	2332232	2332232	0
			.bss	180920	180920	0
			.data	5576	5576	0
			.text	`1294832`	`1294832`	0
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0
			(read/write)	2302816	2302816	0
			.bss	180824	180824	0
			.data	5568	5568	0
			.text	1265416	1265416	0
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0
			(read/write)	1139712	1139712	0
			.bss	11756	11756	0
			.data	4368	4368	0
			.text	103096	103096	0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0
			(read/write)	2053896	2053896	0
			.bss	156876	156876	0
			.data	4864	4864	0
			.text	1016496	1016496	0
p6	all-clusters-app	default	(read/write)	2408048	2408048	0
			.bss	117748	117748	0
			.data	2584	2584	0
			.text	1366312	1366312	0
	light-app	default	(read/write)	2327768	2327784	16
			.bss	105512	105512	0
			.data	2408	2408	0
			.text	1286032	1286048	16
	lock-app	default	(read/write)	`2297208`	`2297208`	0
			.bss	105256	105256	0
			.data	2360	2360	0
			.text	1255472	1255472	0
qpg	lighting-app	qpg6105+debug	(read only)	565568	565584	16
			(read/write)	146936	146936	0
			.bss	89656	89656	0
			.data	1060	1060	0
			.text	560248	560264	16
	lock-app	qpg6105+debug	(read only)	514324	514340	16
			(read/write)	146940	146940	0
			.bss	89128	89128	0
			.data	992	992	0
			.text	509004	509020	16
	persistent-storage-app	qpg6105+debug	(read only)	107140	107140	0
			(read/write)	146940	146940	0
			.bss	38504	38504	0
			.data	288	288	0
			.text	101820	101820	0
telink	lighting-app	tlsr9518adk80d	(read/write)	839534	839622	88
			bss	87460	87460	0
			noinit	37160	37160	0
			text	586050	586136	86

* Fix reading attribute activeLocale failure * Update src/app/clusters/localization-configuration-server/localization-configuration-server.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

Fix reading attribute activeLocale failure

332471a

boring-cyborg bot added the app label Jan 25, 2022

pullapprove bot requested review from robszewczyk, sagar-apple, saurabhst, selissia, tecimovic, vijs, vivien-apple, wbschiller, woody-apple, xylophone21 and yunhanw-google January 25, 2022 18:53

pullapprove bot added the review - pending label Jan 25, 2022

bzbarsky-apple approved these changes Jan 25, 2022

View reviewed changes

src/app/clusters/localization-configuration-server/localization-configuration-server.cpp Outdated Show resolved Hide resolved

Update src/app/clusters/localization-configuration-server/localizatio…

8c053c0

…n-configuration-server.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

saurabhst approved these changes Jan 25, 2022

View reviewed changes

yunhanw-google approved these changes Jan 26, 2022

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Jan 26, 2022

yufengwangca merged commit 2e0f64d into project-chip:master Jan 26, 2022

yufengwangca deleted the pr/cluster/configuration branch January 26, 2022 02:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix reading attribute activeLocale failure #14255

Fix reading attribute activeLocale failure #14255

yufengwangca commented Jan 25, 2022 •

edited

Loading

github-actions bot commented Jan 25, 2022 •

edited

Loading

Fix reading attribute activeLocale failure #14255

Fix reading attribute activeLocale failure #14255

Conversation

yufengwangca commented Jan 25, 2022 • edited Loading

Problem

Change overview

Testing

github-actions bot commented Jan 25, 2022 • edited Loading

yufengwangca commented Jan 25, 2022 •

edited

Loading

github-actions bot commented Jan 25, 2022 •

edited

Loading