Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to Re-enable the TestInetLayerDNS Unit Test #1541

Closed

Conversation

gerickson
Copy link
Contributor

Problem

The CI systems that Project CHIP has employed have historically not supported IPv6. Now that Circle CI has migrated to GitHub Actions, attempt to re-enable tests that require IPv6 support.

Summary of Changes

Moves TestInetLayerDNS from noinst_PROGRAMS back to check_PROGRAMS.

Fixes #329

Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending tests :)

@andy31415
Copy link
Contributor

Approving pending tests :)

@woody-apple: are we sure IPV6 is supported in github actions? The errors seem to indicate otherwise.

actions/runner-images#668 seems to indicate that on may 6 the answer was Unfortunately we can't support this at this time due to infrastructure constraints.

I start wondering if we should instead pull artifacts and run them somwhere else where IPV6 is supported (like circleci with VM or travis or something).

@andy31415
Copy link
Contributor

actions/runner-images#929 seems to document some /etc/host changes that may make things work.

Copy link

@hawk248 hawk248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CLAassistant
Copy link

CLAassistant commented Jul 21, 2020

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
chip-nrf52840-lock-example.out .text 195028 195028
chip-nrf52840-lock-example.out .data -32 -32
chip-nrf52840-lock-example.out .bss 0 -4572
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize
.text,195028,195028
.debug_loc,0,94219
.strtab,0,77111
.debug_info,0,51088
.symtab,0,16256
[Unmapped],0,1576
.debug_macro,0,136
.data,-32,-32
.bss,-4572,0
.debug_abbrev,0,-8110
.debug_aranges,0,-24192
.debug_ranges,0,-29536
.debug_line,0,-46960
.debug_frame,0,-61952
.debug_str,0,-190176


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: integer overflow


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: integer overflow


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After Issue #300 Is Addressed, Move TestInetLayerDNS from noinst_PROGRAMS Back to check_PROGRAMS
9 participants