Update BUILDING.md #172
Merged
Update BUILDING.md #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwalker-apple
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
gerickson,
hawk248,
jelderton,
robszewczyk,
tpmanley and
woody-apple
as code owners
gerickson
approved these changes
Mar 31, 2020
| cd build/<CONFIG> | ||
| ../../configure <CONFIG ARGUMENTS> | ||
| ``` | ||
| Where `<CONFIG>` is something that describes what configuration (as described by `<CONFIG ARGUMENTS>` |
There was a problem hiding this comment.
Is it possible to make these steps part of a script that a user can run to set this up this way?
There was a problem hiding this comment.
The Makefile-Standalone already embodies that of sorts. I'd be reluctant to be much more prescriptive than that since everyone has slightly different styles of working (in tree, out of tree, etc.).
BroderickCarlin
approved these changes
Mar 31, 2020
| cd build/<CONFIG> | ||
| ../../configure <CONFIG ARGUMENTS> | ||
| ``` | ||
| Where `<CONFIG>` is something that describes what configuration (as described by `<CONFIG ARGUMENTS>` |
There was a problem hiding this comment.
nit: It looks like you are missing a closing paren after <CONFIG ARGUMENTS>
woody-apple
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BUILDING.md recommends
outas a build output directory, which leads to questions like "why isn'tout/in .gitignore?"Summary of Changes
move recommended output to build/..., try to shed a bit more light on custom builds
may help address #143