Update ZAP to tip. #19190
Merged
Update ZAP to tip. #19190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
sagar-apple and
saurabhst
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
tcarmelveilleux
approved these changes
Jun 3, 2022
|
PR #19190: Size comparison from 84540b6 to 01a554f Decreases (11 builds for cc13x2_26x2, efr32, linux, nrfconnect, p6)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jun 3, 2022
bzbarsky-apple
force-pushed
the
update-zap
branch
from
01a554f
to
f06ed71
Compare
bzbarsky-apple
force-pushed
the
update-zap
branch
from
f06ed71
to
d047e72
Compare
|
PR #19190: Size comparison from b43b66d to d047e72 Increases (8 builds for cc13x2_26x2, esp32, linux, nrfconnect, p6)
Decreases (7 builds for cc13x2_26x2, efr32, linux)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
approved these changes
Jun 3, 2022
This fixes a bug where we would claim commands in our AcceptedCommandList that we did not actually implement if we happened to be mis-configured to not implement a mandatory command. Enables the mandatory SendKey command in the Keypad Input cluster in all-clusters-app, to keep passing existing tests. Enables the mandatory NavigateTarget command in the Target Navigator cluster in all-clusters-app, to keep passing existing tests.
bzbarsky-apple
force-pushed
the
update-zap
branch
from
d047e72
to
860d1cc
Compare
|
PR #19190: Size comparison from cb5b1b3 to 860d1cc Increases (7 builds for cc13x2_26x2, esp32, linux, p6)
Decreases (5 builds for efr32, linux)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where we would claim commands in our AcceptedCommandList that
we did not actually implement if we happened to be mis-configured to not
implement a mandatory command.
Problem
AcceptedCommandList not matching what commands are actually accepted.
Change overview
Make it match.
Testing
Examined the actual generated code. For example, in
zzz_generated/all-clusters-app/zap-generated/IMClusterCommandHandler.cppthere is no mention of Thermostat, so the claim that we accept theSetpointRaiseLowercommand (before this PR) is just not true.