Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DisarmDone commissionee misssing null check #22146

Merged
merged 3 commits into from Aug 29, 2022
Merged

Fix DisarmDone commissionee misssing null check #22146

merged 3 commits into from Aug 29, 2022

Conversation

panliming-tuya
Copy link
Contributor

Problem

Obviously, commissionee->GetDeviceId() is before the null check.

In low probability cases, after commissioning failure before WiFiNetworkSetup and the device session be removed, crash will accur.

Change overview

Change commissionee->GetDeviceId() to NodeId nodeId = mDeviceBeingCommissioned->GetDeviceId()

@panliming-tuya
Fix DisarmDone commissionee misssing null check
54ff150 
Problem: Obviously invoke commitee pointer is before the null check.
In low probability cases, commissioning failure before WiFiNetworkSetup and removing the device connection in the App will cause crash.
@panliming-tuya
Make sure nodeId has a value.
1e9ac7c
@panliming-tuya panliming-tuya changed the title Fix disarmdone crash Fix DisarmDone commissionee misssing null check Aug 25, 2022
@pullapprove pullapprove bot removed the controller label Aug 25, 2022
@github-actions
Copy link

github-actions bot commented Aug 25, 2022 •
edited

PR #22146: Size comparison from 3a2337e to 1e9ac7c

Increases (5 builds for bl602, cc13x2_26x2, esp32, psoc6)
platform target config section 3a2337e 1e9ac7c change % change
bl602 lighting-app bl602 (read/write) 1383642 1383650 8 0.0
.text 1050812 1050816 4 0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 180704 180712 8 0.0
esp32 all-clusters-app c3devkit (read only) 1031038 1031040 2 0.0
.flash.text 1031038 1031040 2 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 2664473 26644737 1 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26381431 26381432 1 0.0
Decreases (5 builds for bl602, cc13x2_26x2, cyw30739, linux)
platform target config section 3a2337e 1e9ac7c change % change
bl602 lighting-app bl602+rpc (read/write) 1429306 1429298 -8 -0.0
.text 1082576 1082572 -4 -0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 656687 656679 -8 -0.0
.text 554440 554432 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586586 586578 -8 -0.0
.app_xip_area 463244 463236 -8 -0.0
lock cyw930739m2evb_01 (read/write) 592346 592338 -8 -0.0
.app_xip_area 464220 464212 -8 -0.0
linux chip-tool-ipv6only arm64 (read only) 10259508 10259492 -16 -0.0
.text 8127988 8127972 -16 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section 3a2337e 1e9ac7c change % change
bl602 lighting-app bl602 (read/write) 1383642 1383650 8 0.0
.bss 120266 120266 0 0.0
.data 4480 4480 0 0.0
.text 1050812 1050816 4 0.0
bl602+rpc (read/write) 1429306 1429298 -8 -0.0
.bss 127706 127706 0 0.0
.data 4600 4600 0 0.0
.text 1082576 1082572 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672835 672835 0 0.0
(read/write) 178660 178660 0 0.0
.bss 74388 74388 0 0.0
.data 3372 3372 0 0.0
.rodata 88835 88835 0 0.0
.text 583684 583684 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637555 637555 0 0.0
(read/write) 157948 157948 0 0.0
.bss 73660 73660 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559252 559252 0 0.0
lock-ftd LP_CC2652R7 (read only) 673919 673919 0 0.0
(read/write) 167784 167784 0 0.0
.bss 71484 71484 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596768 596768 0 0.0
lock-mtd LP_CC2652R7 (read only) 656687 656679 -8 -0.0
(read/write) 180704 180712 8 0.0
.bss 67172 67172 0 0.0
.data 3296 3296 0 0.0
.rodata 101767 101767 0 0.0
.text 554440 554432 -8 -0.0
pump-app LP_CC2652R7 (read only) 684551 684551 0 0.0
(read/write) 157960 157960 0 0.0
.bss 71524 71524 0 0.0
.data 3296 3296 0 0.0
.rodata 89927 89927 0 0.0
.text 594140 594140 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669059 669059 0 0.0
(read/write) 173572 173572 0 0.0
.bss 71644 71644 0 0.0
.data 3292 3292 0 0.0
.rodata 85483 85483 0 0.0
.text 583096 583096 0 0.0
shell LP_CC2652R7 (read only) 665526 665526 0 0.0
(read/write) 181488 181488 0 0.0
.bss 76708 76708 0 0.0
.data 3376 3376 0 0.0
.rodata 85782 85782 0 0.0
.text 579428 579428 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586586 586578 -8 -0.0
.app_xip_area 463244 463236 -8 -0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592346 592338 -8 -0.0
.app_xip_area 464220 464212 -8 -0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599442 599442 0 0.0
.app_xip_area 476820 476820 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1107316 1107316 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 968892 968892 0 0.0
BRD4161A+rpc (read/write) 971396 971396 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 818276 818276 0 0.0
BRD4161A+rs911x (read/write) 999928 999928 0 0.0
.bss 169088 169088 0 0.0
.data 2056 2056 0 0.0
.text 828764 828764 0 0.0
lock-app BRD4161A+wf200 (read/write) 1149196 1149196 0 0.0
.bss 152168 152168 0 0.0
.data 2064 2064 0 0.0
.text 994944 994944 0 0.0
window-app BRD4161A (read/write) 1098580 1098580 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 958692 958692 0 0.0
esp32 all-clusters-app c3devkit (read only) 1031038 1031040 2 0.0
(read/write) 1489610 1489610 0 0.0
.dram0.bss 71144 71144 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 218424 218424 0 0.0
.flash.text 1031038 1031040 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1084175 1084175 0 0.0
(read/write) 491528 491528 0 0.0
.dram0.bss 76648 76648 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248740 248740 0 0.0
.flash.text 1078791 1078791 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 646516 646516 0 0.0
.bss 70400 70400 0 0.0
.data 2068 2068 0 0.0
.text 571320 571320 0 0.0
lock k32w0+release (read/write) 704012 704012 0 0.0
.bss 70864 70864 0 0.0
.data 2076 2076 0 0.0
.text 628344 628344 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10259508 10259492 -16 -0.0
(read/write) 699169 699169 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 643848 643848 0 0.0
.dynamic 560 560 0 0.0
.got 13784 13784 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493364 493364 0 0.0
.text 8127988 8127972 -16 -0.0
thermostat-no-ble arm64 (read only) 2356644 2356644 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140588 140588 0 0.0
.text 1978336 1978336 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454312 2454312 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1416956 1416956 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180591 1180591 0 0.0
bss 143745 143745 0 0.0
rodata 143328 143328 0 0.0
text 814560 814560 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159675 1159675 0 0.0
bss 142972 142972 0 0.0
rodata 134916 134916 0 0.0
text 802968 802968 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 881000 881000 0 0.0
(read/write) 1700692 1700692 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 149688 149688 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1217526 1217526 0 0.0
.debug_aranges 111544 111544 0 0.0
.debug_frame 372400 372400 0 0.0
.debug_info 2664473 26644737 1 0.0
.debug_line 3646957 3646957 0 0.0
.debug_loc 3561998 3561998 0 0.0
.debug_ranges 336696 336696 0 0.0
.debug_str 3393533 3393533 0 0.0
.heap 881000 881000 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569137 569137 0 0.0
.symtab 420320 420320 0 0.0
.text 1539960 1539960 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 881736 881736 0 0.0
(read/write) 1643884 1643884 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 148952 148952 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1209365 1209365 0 0.0
.debug_aranges 111016 111016 0 0.0
.debug_frame 375480 375480 0 0.0
.debug_info 26381431 26381432 1 0.0
.debug_line 3667361 3667361 0 0.0
.debug_loc 3549635 3549635 0 0.0
.debug_ranges 335312 335312 0 0.0
.debug_str 3382522 3382522 0 0.0
.heap 881736 881736 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533611 533611 0 0.0
.symtab 406912 406912 0 0.0
.text 1483888 1483888 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 890080 890080 0 0.0
(read/write) 1561132 1561132 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 140816 140816 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2448 2448 0 0.0
.debug_abbrev 1044038 1044038 0 0.0
.debug_aranges 103184 103184 0 0.0
.debug_frame 345724 345724 0 0.0
.debug_info 21845988 21845988 0 0.0
.debug_line 3238540 3238540 0 0.0
.debug_loc 3249150 3249150 0 0.0
.debug_ranges 301152 301152 0 0.0
.debug_str 3188616 3188616 0 0.0
.heap 890080 890080 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 466892 466892 0 0.0
.symtab 373968 373968 0 0.0
.text 1409480 1409480 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 885584 885584 0 0.0
(read/write) 1598372 1598372 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 145296 145296 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1051210 1051210 0 0.0
.debug_aranges 103856 103856 0 0.0
.debug_frame 348548 348548 0 0.0
.debug_info 22199262 22199262 0 0.0
.debug_line 3247103 3247103 0 0.0
.debug_loc 3289002 3289002 0 0.0
.debug_ranges 304496 304496 0 0.0
.debug_str 3216047 3216047 0 0.0
.heap 885584 885584 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473107 473107 0 0.0
.symtab 377152 377152 0 0.0
.text 1442224 1442224 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808416 808416 0 0.0
bss 71448 71448 0 0.0
noinit 43488 43488 0 0.0
text 571026 571026 0 0.0
lighting-app tlsr9518adk80d (read/write) 830392 830392 0 0.0
bss 72304 72304 0 0.0
noinit 43488 43488 0 0.0
text 589150 589150 0 0.0

@woody-apple woody-apple enabled auto-merge (squash) August 25, 2022 17:47
@github-actions
Copy link

github-actions bot commented Aug 29, 2022 •
edited

PR #22146: Size comparison from 55f9049 to bfaeec7

Increases (3 builds for cc13x2_26x2, nrfconnect)
platform target config section 55f9049 bfaeec7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672931 672939 8 0.0
.text 583780 583788 8 0.0
shell LP_CC2652R7 (read only) 665622 665630 8 0.0
.text 579524 579532 8 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 803052 803056 4 0.0
Decreases (11 builds for cc13x2_26x2, esp32, linux, nrfconnect, psoc6, telink)
platform target config section 55f9049 bfaeec7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 178460 178452 -8 -0.0
shell LP_CC2652R7 (read/write) 181288 181280 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1031342 1031340 -2 -0.0
.flash.text 1031342 1031340 -2 -0.0
linux chip-tool-ipv6only arm64 (read only) 10281380 10281364 -16 -0.0
.text 8135700 8135684 -16 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 814648 814644 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26654692 26654690 -2 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26391387 26391386 -1 -0.0
light cy8ckit_062s2_43012 .debug_info 21854899 21854898 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 22234628 22234627 -1 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 808540 808532 -8 -0.0
text 571158 571156 -2 -0.0
lighting-app tlsr9518adk80d text 589252 589250 -2 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section 55f9049 bfaeec7 change % change
bl602 lighting-app bl602 (read/write) 1383746 1383746 0 0.0
.bss 120266 120266 0 0.0
.data 4480 4480 0 0.0
.text 1050912 1050912 0 0.0
bl602+rpc (read/write) 1429658 1429658 0 0.0
.bss 127706 127706 0 0.0
.data 4600 4600 0 0.0
.text 1082928 1082928 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672931 672939 8 0.0
(read/write) 178460 178452 -8 -0.0
.bss 74284 74284 0 0.0
.data 3372 3372 0 0.0
.rodata 88835 88835 0 0.0
.text 583780 583788 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637659 637659 0 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559356 559356 0 0.0
lock-ftd LP_CC2652R7 (read only) 673991 673991 0 0.0
(read/write) 167712 167712 0 0.0
.bss 71484 71484 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596840 596840 0 0.0
lock-mtd LP_CC2652R7 (read only) 656743 656743 0 0.0
(read/write) 180648 180648 0 0.0
.bss 67172 67172 0 0.0
.data 3296 3296 0 0.0
.rodata 101767 101767 0 0.0
.text 554496 554496 0 0.0
pump-app LP_CC2652R7 (read only) 684655 684655 0 0.0
(read/write) 157752 157752 0 0.0
.bss 71420 71420 0 0.0
.data 3296 3296 0 0.0
.rodata 89927 89927 0 0.0
.text 594244 594244 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669147 669147 0 0.0
(read/write) 173372 173372 0 0.0
.bss 71532 71532 0 0.0
.data 3292 3292 0 0.0
.rodata 85483 85483 0 0.0
.text 583184 583184 0 0.0
shell LP_CC2652R7 (read only) 665622 665630 8 0.0
(read/write) 181288 181280 -8 -0.0
.bss 76604 76604 0 0.0
.data 3376 3376 0 0.0
.rodata 85782 85782 0 0.0
.text 579524 579532 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586642 586642 0 0.0
.app_xip_area 463300 463300 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592410 592410 0 0.0
.app_xip_area 464284 464284 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599538 599538 0 0.0
.app_xip_area 476916 476916 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1107372 1107372 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 968948 968948 0 0.0
BRD4161A+rpc (read/write) 971476 971476 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 818356 818356 0 0.0
BRD4161A+rs911x (read/write) 999976 999976 0 0.0
.bss 169088 169088 0 0.0
.data 2056 2056 0 0.0
.text 828812 828812 0 0.0
lock-app BRD4161A+wf200 (read/write) 1149260 1149260 0 0.0
.bss 152168 152168 0 0.0
.data 2064 2064 0 0.0
.text 995008 995008 0 0.0
window-app BRD4161A (read/write) 1098644 1098644 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 958756 958756 0 0.0
esp32 all-clusters-app c3devkit (read only) 1031342 1031340 -2 -0.0
(read/write) 1489538 1489538 0 0.0
.dram0.bss 71056 71056 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 218448 218448 0 0.0
.flash.text 1031342 1031340 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1084363 1084363 0 0.0
(read/write) 491460 491460 0 0.0
.dram0.bss 76560 76560 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248760 248760 0 0.0
.flash.text 1078979 1078979 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 646564 646564 0 0.0
.bss 70400 70400 0 0.0
.data 2068 2068 0 0.0
.text 571368 571368 0 0.0
lock k32w0+release (read/write) 704076 704076 0 0.0
.bss 70864 70864 0 0.0
.data 2076 2076 0 0.0
.text 628408 628408 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10281380 10281364 -16 -0.0
(read/write) 705073 705073 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 649704 649704 0 0.0
.dynamic 560 560 0 0.0
.got 13832 13832 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493556 493556 0 0.0
.text 8135700 8135684 -16 -0.0
thermostat-no-ble arm64 (read only) 2357812 2357812 0 0.0
(read/write) 141681 141681 0 0.0
.bss 55217 55217 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140636 140636 0 0.0
.text 1979472 1979472 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454408 2454408 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417052 1417052 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180591 1180591 0 0.0
bss 143641 143641 0 0.0
rodata 143360 143360 0 0.0
text 814648 814644 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159787 1159787 0 0.0
bss 142868 142868 0 0.0
rodata 134948 134948 0 0.0
text 803052 803056 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842224 842224 0 0.0
(read/write) 1740428 1740428 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188464 188464 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1217456 1217456 0 0.0
.debug_aranges 111552 111552 0 0.0
.debug_frame 372464 372464 0 0.0
.debug_info 26654692 26654690 -2 -0.0
.debug_line 3648656 3648656 0 0.0
.debug_loc 3565182 3565182 0 0.0
.debug_ranges 337376 337376 0 0.0
.debug_str 3404479 3404479 0 0.0
.heap 842224 842224 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569432 569432 0 0.0
.symtab 420608 420608 0 0.0
.text 1540920 1540920 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842960 842960 0 0.0
(read/write) 1683620 1683620 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187728 187728 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1209295 1209295 0 0.0
.debug_aranges 111024 111024 0 0.0
.debug_frame 375544 375544 0 0.0
.debug_info 26391387 26391386 -1 -0.0
.debug_line 3669060 3669060 0 0.0
.debug_loc 3552819 3552819 0 0.0
.debug_ranges 335992 335992 0 0.0
.debug_str 3393468 3393468 0 0.0
.heap 842960 842960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533906 533906 0 0.0
.symtab 407200 407200 0 0.0
.text 1484848 1484848 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 851200 851200 0 0.0
(read/write) 1600892 1600892 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179696 179696 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2448 2448 0 0.0
.debug_abbrev 1044114 1044114 0 0.0
.debug_aranges 103200 103200 0 0.0
.debug_frame 345812 345812 0 0.0
.debug_info 21854899 21854898 -1 -0.0
.debug_line 3239693 3239693 0 0.0
.debug_loc 3251125 3251125 0 0.0
.debug_ranges 301464 301464 0 0.0
.debug_str 3198712 3198712 0 0.0
.heap 851200 851200 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 467205 467205 0 0.0
.symtab 374288 374288 0 0.0
.text 1410360 1410360 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 846168 846168 0 0.0
(read/write) 1638604 1638604 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184712 184712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1051549 1051549 0 0.0
.debug_aranges 103872 103872 0 0.0
.debug_frame 348640 348640 0 0.0
.debug_info 22234628 22234627 -1 -0.0
.debug_line 3248587 3248587 0 0.0
.debug_loc 3290963 3290963 0 0.0
.debug_ranges 304808 304808 0 0.0
.debug_str 3226195 3226195 0 0.0
.heap 846168 846168 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473420 473420 0 0.0
.symtab 377472 377472 0 0.0
.text 1443040 1443040 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808540 808532 -8 -0.0
bss 71344 71344 0 0.0
noinit 43488 43488 0 0.0
text 571158 571156 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 830416 830416 0 0.0
bss 72200 72200 0 0.0
noinit 43488 43488 0 0.0
text 589252 589250 -2 -0.0

@woody-apple woody-apple merged commit 16edce7 into project-chip:master Aug 29, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@panliming-tuya @isiu-apple
Fix DisarmDone commissionee misssing null check (project-chip#22146)
c11ed05 
* Fix DisarmDone commissionee misssing null check

Problem: Obviously invoke commitee pointer is before the null check.
In low probability cases, commissioning failure before WiFiNetworkSetup and removing the device connection in the App will cause crash.

* Make sure nodeId has a value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@woody-apple woody-apple woody-apple approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@panliming-tuya @andy31415 @woody-apple @bzbarsky-apple