Fix in-place save for DefaultSessionResumptionStorage #23062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msandstedt
requested review from
bzbarsky-apple,
tcarmelveilleux and
andy31415
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google and
mrjerryjohns
smides-nest
reviewed
Oct 7, 2022
src/protocols/secure_channel/DefaultSessionResumptionStorage.cpp
Outdated
Show resolved
Hide resolved
msandstedt
force-pushed
the
bugfix/23044
branch
from
26113c2
to
ae0fbe3
Compare
Nodes that already exist in the DefaultSessionResumptionStorage index are consuming additional entries in the index on save, and aren't cleaned from the link and state tables first. This has the following consequences: 1. If session resumption storage is full, this causes unnecessary eviction of records for other nodes. 2. This pulls the index out of sync from the backing state table because duplicate entries in the index for a given node only map map to a single node-id-keyed entry in the state table. 3. An entry in the link table is leaked on each occurrence, as the resumption-id-keyed link entry will be orphaned once its associated state table entry is overwritten. This commit fixes the problem by first deleting the link table entry before saving a record for a node that already exists in the table. Save is also simplified in this case by not rewriting the index, as the node is already in the index.
msandstedt
force-pushed
the
bugfix/23044
branch
from
ae0fbe3
to
e0007b3
Compare
|
PR #23062: Size comparison from 0bff5ad to e0007b3 Increases (32 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (32 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, linux, nrfconnect, psoc6, qpg, telink)
|
src/protocols/secure_channel/tests/TestDefaultSessionResumptionStorage.cpp
Show resolved
Hide resolved
tcarmelveilleux
approved these changes
Oct 7, 2022
|
PR #23062: Size comparison from 0bff5ad to 03fb7d9 Increases above 0.2%:
Increases (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 7, 2022
|
PR #23062: Size comparison from 0bff5ad to 1029f85 Increases (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
|
src/protocols/secure_channel/tests/TestDefaultSessionResumptionStorage.cpp
Show resolved
Hide resolved
| NL_TEST_ASSERT(inSuite, vector.cats.values[1] == outCats.values[1]); | ||
| NL_TEST_ASSERT(inSuite, vector.cats.values[2] == outCats.values[2]); | ||
|
|
||
| // Validate retreiveal by resumption ID. |
There was a problem hiding this comment.
PR here: #23110.
src/protocols/secure_channel/tests/TestDefaultSessionResumptionStorage.cpp
Show resolved
Hide resolved
src/protocols/secure_channel/tests/TestDefaultSessionResumptionStorage.cpp
Show resolved
Hide resolved
msandstedt
added a commit
to msandstedt/connectedhomeip
that referenced
this pull request
Oct 11, 2022
Apply suggestions per bzbarsky-apple
andy31415
pushed a commit
that referenced
this pull request
Oct 11, 2022
msandstedt
added a commit
to msandstedt/connectedhomeip
that referenced
this pull request
Oct 13, 2022
…3062) Nodes that already exist in the DefaultSessionResumptionStorage index are consuming additional entries in the index on save, and aren't cleaned from the link and state tables first. This has the following consequences: 1. If session resumption storage is full, this causes unnecessary eviction of records for other nodes. 2. This pulls the index out of sync from the backing state table because duplicate entries in the index for a given node only map to a single node-id-keyed entry in the state table. 3. An entry in the link table is leaked on each occurrence, as the resumption-id-keyed link entry will be orphaned once its associated state table entry is overwritten. A symptom of this can be seen in the DeleteAll(FabricIndex fabricIndex) method, which will often log errors due to the index being out of sync form the state table. This commit fixes the problem by first deleting the link table entry before saving a record for a node that already exists in the table. Save is also simplified in this case by not rewriting the index, as the node is already in the index. To prevent future problems, unit test code has been added for DefaultSessionResumptionStorage to verify that DeleteAll is completing without errors and that no link or state table entries are leaked. (cherry picked from commit f6d585a)
msandstedt
added a commit
to msandstedt/connectedhomeip
that referenced
this pull request
Oct 13, 2022
) Apply suggestions per bzbarsky-apple (cherry picked from commit 2a1cf85)
tima-q
pushed a commit
to Qorvo/connectedhomeip
that referenced
this pull request
Oct 13, 2022
…3062) Nodes that already exist in the DefaultSessionResumptionStorage index are consuming additional entries in the index on save, and aren't cleaned from the link and state tables first. This has the following consequences: 1. If session resumption storage is full, this causes unnecessary eviction of records for other nodes. 2. This pulls the index out of sync from the backing state table because duplicate entries in the index for a given node only map to a single node-id-keyed entry in the state table. 3. An entry in the link table is leaked on each occurrence, as the resumption-id-keyed link entry will be orphaned once its associated state table entry is overwritten. A symptom of this can be seen in the DeleteAll(FabricIndex fabricIndex) method, which will often log errors due to the index being out of sync form the state table. This commit fixes the problem by first deleting the link table entry before saving a record for a node that already exists in the table. Save is also simplified in this case by not rewriting the index, as the node is already in the index. To prevent future problems, unit test code has been added for DefaultSessionResumptionStorage to verify that DeleteAll is completing without errors and that no link or state table entries are leaked.
dvdm-qorvo
pushed a commit
to Qorvo/connectedhomeip
that referenced
this pull request
Oct 13, 2022
…3062) Nodes that already exist in the DefaultSessionResumptionStorage index are consuming additional entries in the index on save, and aren't cleaned from the link and state tables first. This has the following consequences: 1. If session resumption storage is full, this causes unnecessary eviction of records for other nodes. 2. This pulls the index out of sync from the backing state table because duplicate entries in the index for a given node only map to a single node-id-keyed entry in the state table. 3. An entry in the link table is leaked on each occurrence, as the resumption-id-keyed link entry will be orphaned once its associated state table entry is overwritten. A symptom of this can be seen in the DeleteAll(FabricIndex fabricIndex) method, which will often log errors due to the index being out of sync form the state table. This commit fixes the problem by first deleting the link table entry before saving a record for a node that already exists in the table. Save is also simplified in this case by not rewriting the index, as the node is already in the index. To prevent future problems, unit test code has been added for DefaultSessionResumptionStorage to verify that DeleteAll is completing without errors and that no link or state table entries are leaked.
andy31415
pushed a commit
that referenced
this pull request
Oct 13, 2022
* Fix in-place save for DefaultSessionResumptionStorage (#23062) Nodes that already exist in the DefaultSessionResumptionStorage index are consuming additional entries in the index on save, and aren't cleaned from the link and state tables first. This has the following consequences: 1. If session resumption storage is full, this causes unnecessary eviction of records for other nodes. 2. This pulls the index out of sync from the backing state table because duplicate entries in the index for a given node only map to a single node-id-keyed entry in the state table. 3. An entry in the link table is leaked on each occurrence, as the resumption-id-keyed link entry will be orphaned once its associated state table entry is overwritten. A symptom of this can be seen in the DeleteAll(FabricIndex fabricIndex) method, which will often log errors due to the index being out of sync form the state table. This commit fixes the problem by first deleting the link table entry before saving a record for a node that already exists in the table. Save is also simplified in this case by not rewriting the index, as the node is already in the index. To prevent future problems, unit test code has been added for DefaultSessionResumptionStorage to verify that DeleteAll is completing without errors and that no link or state table entries are leaked. (cherry picked from commit f6d585a) * Minor style and comment fixes for #23062 (#23110) Apply suggestions per bzbarsky-apple (cherry picked from commit 2a1cf85)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodes that already exist in the DefaultSessionResumptionStorage index are consuming additional entries in the index on save, and aren't cleaned from the link and state tables first. This has the following consequences:
This commit fixes the problem by first deleting the link table entry before saving a record for a node that already exists in the table. Save is also simplified in this case by not rewriting the index, as the node is already in the index.
Fixes #23044