Fix delivery of urgent events to actually work correctly. #23240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
mspang,
rgoliver and
saurabhst
bzbarsky-apple
force-pushed
the
fix-urgent-event-delivery
branch
from
caf7c96
to
c1afda4
Compare
|
PR #23240: Size comparison from b9cf4b9 to c1afda4 Increases (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
fix-urgent-event-delivery
branch
2 times, most recently
from
12535dc
to
493a51f
Compare
If an urgent event was emitted at a point when the ReadHandler subscribing for it had already gotten its "min interval has elapsed" callback, we would just mark the read handler dirty but not schedule a run of the reporting engine. This would cause us to not report the event until something _did_ trigger such a run (either the max interval being reached, or some other reading/reporting activity). The fix is to make sure ReadHandler always schedules a run when IsReportable() becomes true.
bzbarsky-apple
force-pushed
the
fix-urgent-event-delivery
branch
from
493a51f
to
2947a8f
Compare
|
PR #23240: Size comparison from 8b30d71 to 2947a8f Increases (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (12 builds for bl702, cc13x2_26x2, psoc6)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mrjerryjohns
approved these changes
Oct 19, 2022
|
PR #23240: Size comparison from 8b30d71 to d010fa2 Increases (28 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (13 builds for bl702, cc13x2_26x2, psoc6, telink)
Full report (31 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
fix-urgent-event-delivery
branch
from
b307a26
to
54d2603
Compare
|
PR #23240: Size comparison from f76da55 to 54d2603 Increases (8 builds for bl702, mbed, nrfconnect, telink)
Decreases (2 builds for bl702)
Full report (8 builds for bl702, mbed, nrfconnect, telink)
|
jtung-apple
approved these changes
Oct 20, 2022
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Oct 20, 2022
…ip#23240) * Fix delivery of urgent events to actually work correctly. If an urgent event was emitted at a point when the ReadHandler subscribing for it had already gotten its "min interval has elapsed" callback, we would just mark the read handler dirty but not schedule a run of the reporting engine. This would cause us to not report the event until something _did_ trigger such a run (either the max interval being reached, or some other reading/reporting activity). The fix is to make sure ReadHandler always schedules a run when IsReportable() becomes true. * Address review comments. * Make TestSubscribeUrgentWildcardEvent slightly less random-failure-prone.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Oct 20, 2022
…ip#23240) * Fix delivery of urgent events to actually work correctly. If an urgent event was emitted at a point when the ReadHandler subscribing for it had already gotten its "min interval has elapsed" callback, we would just mark the read handler dirty but not schedule a run of the reporting engine. This would cause us to not report the event until something _did_ trigger such a run (either the max interval being reached, or some other reading/reporting activity). The fix is to make sure ReadHandler always schedules a run when IsReportable() becomes true. * Address review comments. * Make TestSubscribeUrgentWildcardEvent slightly less random-failure-prone.
andy31415
pushed a commit
that referenced
this pull request
Oct 22, 2022
…23271) * Fix delivery of urgent events to actually work correctly. If an urgent event was emitted at a point when the ReadHandler subscribing for it had already gotten its "min interval has elapsed" callback, we would just mark the read handler dirty but not schedule a run of the reporting engine. This would cause us to not report the event until something _did_ trigger such a run (either the max interval being reached, or some other reading/reporting activity). The fix is to make sure ReadHandler always schedules a run when IsReportable() becomes true. * Address review comments. * Make TestSubscribeUrgentWildcardEvent slightly less random-failure-prone.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…ip#23240) * Fix delivery of urgent events to actually work correctly. If an urgent event was emitted at a point when the ReadHandler subscribing for it had already gotten its "min interval has elapsed" callback, we would just mark the read handler dirty but not schedule a run of the reporting engine. This would cause us to not report the event until something _did_ trigger such a run (either the max interval being reached, or some other reading/reporting activity). The fix is to make sure ReadHandler always schedules a run when IsReportable() becomes true. * Address review comments. * Make TestSubscribeUrgentWildcardEvent slightly less random-failure-prone.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…ip#23240) * Fix delivery of urgent events to actually work correctly. If an urgent event was emitted at a point when the ReadHandler subscribing for it had already gotten its "min interval has elapsed" callback, we would just mark the read handler dirty but not schedule a run of the reporting engine. This would cause us to not report the event until something _did_ trigger such a run (either the max interval being reached, or some other reading/reporting activity). The fix is to make sure ReadHandler always schedules a run when IsReportable() becomes true. * Address review comments. * Make TestSubscribeUrgentWildcardEvent slightly less random-failure-prone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an urgent event was emitted at a point when the ReadHandler subscribing for it had already gotten its "min interval has elapsed" callback, we would just mark the read handler dirty but not schedule a run of the reporting engine. This would cause us to not report the event until something did trigger such a run (either the max interval being reached, or some other reading/reporting activity).
The fix is to make sure ReadHandler always schedules a run when IsReportable() becomes true.