Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ameba] Fix Trailing Null #23485

Merged
merged 1 commit into from Nov 10, 2022
Merged

[Ameba] Fix Trailing Null #23485

merged 1 commit into from Nov 10, 2022

Conversation

pankore
Copy link
Contributor

@pankore pankore commented Nov 4, 2022 •
edited

  • TC-BINFO-2.1 when reading location, it shows 3 chars. Remove trailing null after getPref_str_new
  • This is a cherry-pick of PR [Ameba] Fix Trailing Null #22836 from master

@github-actions
Copy link

github-actions bot commented Nov 4, 2022 •
edited

PR #23485: Size comparison from a17c005 to 34427ba

Increases (2 builds for nrfconnect, psoc6)
platform target config section a17c005 34427ba change % change
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1161207 1161223 16 0.0
text 803376 803380 4 0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22403802 22403804 2 0.0
Decreases (2 builds for esp32, psoc6)
platform target config section a17c005 34427ba change % change
esp32 all-clusters-app c3devkit (read only) 1223280 1223276 -4 -0.0
.flash.text 1223280 1223276 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26823474 26823473 -1 -0.0
Full report (24 builds for cc13x2_26x2, cyw30739, efr32, esp32, mbed, nrfconnect, psoc6)
platform target config section a17c005 34427ba change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677083 677083 0 0.0
(read/write) 174452 174452 0 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89859 89859 0 0.0
.text 586912 586912 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 641323 641323 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 78995 78995 0 0.0
.text 562008 562008 0 0.0
lock-ftd LP_CC2652R7 (read only) 678615 678615 0 0.0
(read/write) 170088 170088 0 0.0
.bss 78484 78484 0 0.0
.data 3304 3304 0 0.0
.rodata 77543 77543 0 0.0
.text 600592 600592 0 0.0
lock-mtd LP_CC2652R7 (read only) 662435 662435 0 0.0
(read/write) 181956 181956 0 0.0
.bss 74172 74172 0 0.0
.data 3304 3304 0 0.0
.rodata 103371 103371 0 0.0
.text 558584 558584 0 0.0
pump-app LP_CC2652R7 (read only) 687815 687815 0 0.0
(read/write) 161592 161592 0 0.0
.bss 78420 78420 0 0.0
.data 3296 3296 0 0.0
.rodata 90799 90799 0 0.0
.text 596532 596532 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672299 672299 0 0.0
(read/write) 177220 177220 0 0.0
.bss 78532 78532 0 0.0
.data 3292 3292 0 0.0
.rodata 86347 86347 0 0.0
.text 585472 585472 0 0.0
shell LP_CC2652R7 (read only) 668070 668070 0 0.0
(read/write) 185776 185776 0 0.0
.bss 83540 83540 0 0.0
.data 3376 3376 0 0.0
.rodata 86566 86566 0 0.0
.text 581188 581188 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587738 587738 0 0.0
.app_xip_area 464364 464364 0 0.0
.bss 65792 65792 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 594786 594786 0 0.0
.app_xip_area 466084 466084 0 0.0
.bss 71112 71112 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543822 543822 0 0.0
.app_xip_area 425504 425504 0 0.0
.bss 60784 60784 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1110344 1110344 0 0.0
.bss 136340 136340 0 0.0
.data 2072 2072 0 0.0
.text 971912 971912 0 0.0
BRD4161A+rpc (read/write) 973708 973708 0 0.0
.bss 150852 150852 0 0.0
.data 2252 2252 0 0.0
.text 820580 820580 0 0.0
BRD4161A+rs911x (read/write) 1003632 1003632 0 0.0
.bss 169176 169176 0 0.0
.data 2064 2064 0 0.0
.text 832372 832372 0 0.0
lock-app BRD4161A+wf200 (read/write) 1151260 1151260 0 0.0
.bss 152264 152264 0 0.0
.data 2072 2072 0 0.0
.text 996904 996904 0 0.0
window-app BRD4161A (read/write) 1103940 1103940 0 0.0
.bss 137788 137788 0 0.0
.data 2096 2096 0 0.0
.text 964036 964036 0 0.0
esp32 all-clusters-app c3devkit (read only) 1223280 1223276 -4 -0.0
(read/write) 1788390 1788390 0 0.0
.dram0.bss 76944 76944 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 257960 257960 0 0.0
.flash.text 1223280 1223276 -4 -0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1233299 1233299 0 0.0
(read/write) 564300 564300 0 0.0
.dram0.bss 82304 82304 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 315032 315032 0 0.0
.flash.text 1227915 1227915 0 0.0
.iram0.text 123939 123939 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2456176 2456176 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1418820 1418820 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182571 1182571 0 0.0
bss 143633 143633 0 0.0
rodata 144476 144476 0 0.0
text 815512 815512 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1161207 1161223 16 0.0
bss 142860 142860 0 0.0
rodata 136048 136048 0 0.0
text 803376 803380 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1745052 1745052 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229252 1229252 0 0.0
.debug_aranges 111864 111864 0 0.0
.debug_frame 373508 373508 0 0.0
.debug_info 26823474 26823473 -1 -0.0
.debug_line 3671142 3671142 0 0.0
.debug_loc 3584653 3584653 0 0.0
.debug_ranges 340264 340264 0 0.0
.debug_str 3440224 3440224 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569768 569768 0 0.0
.symtab 421248 421248 0 0.0
.text 1545288 1545288 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1687652 1687652 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221051 1221051 0 0.0
.debug_aranges 111336 111336 0 0.0
.debug_frame 376588 376588 0 0.0
.debug_info 26560255 26560255 0 0.0
.debug_line 3691858 3691858 0 0.0
.debug_loc 3572290 3572290 0 0.0
.debug_ranges 338880 338880 0 0.0
.debug_str 3429237 3429237 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533857 533857 0 0.0
.symtab 407680 407680 0 0.0
.text 1488624 1488624 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850896 850896 0 0.0
(read/write) 1606196 1606196 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179992 179992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1055107 1055107 0 0.0
.debug_aranges 103544 103544 0 0.0
.debug_frame 346916 346916 0 0.0
.debug_info 22024450 22024450 0 0.0
.debug_line 3261776 3261776 0 0.0
.debug_loc 3270322 3270322 0 0.0
.debug_ranges 304208 304208 0 0.0
.debug_str 3234769 3234769 0 0.0
.heap 850896 850896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 470234 470234 0 0.0
.symtab 376128 376128 0 0.0
.text 1415360 1415360 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845864 845864 0 0.0
(read/write) 1644060 1644060 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185008 185008 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1062526 1062526 0 0.0
.debug_aranges 104216 104216 0 0.0
.debug_frame 349740 349740 0 0.0
.debug_info 22403802 22403804 2 0.0
.debug_line 3270491 3270491 0 0.0
.debug_loc 3310181 3310181 0 0.0
.debug_ranges 307552 307552 0 0.0
.debug_str 3262224 3262224 0 0.0
.heap 845864 845864 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476474 476474 0 0.0
.symtab 379360 379360 0 0.0
.text 1448192 1448192 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0

@andy31415
Copy link
Contributor

@pankore is this a cherrypick? If yes please reference it in the description (using a #<number> reference ... otherwise things like full URLs will not be identified by the bot) to make the Require Issues for PRs check happy.

If not a cherrypick, please fix this in master first, then cherrypick into 1.0.

@pankore
Copy link
Contributor Author

pankore commented Nov 9, 2022

Hi @andy31415, understood. I have added the reference PR in the description.

@pankore
[Ameba] Fix Trailing Null
256ad9c 
* TC-BINFO-2.1 when reading location, it shows 3 chars. Remove trailing null after getPref_str_new
@andy31415 andy31415 merged commit 4744889 into project-chip:v1.0-branch Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

Assignees
No one assigned
Labels
platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pankore @andy31415 @bzbarsky-apple