Set the cache-flush bit for "unique" records in minimal mdns. #23933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There should only be one entity around with a given Matter instance name or Matter hostname, so all records which have those as the QName are part of the unique set. Fixes project-chip#23918
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple and
gjc13
pullapprove
bot
requested review from
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
msandstedt,
rgoliver and
robszewczyk
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
andy31415
approved these changes
Dec 6, 2022
Damian-Nordic
approved these changes
Dec 6, 2022
|
PR #23933: Size comparison from f71e778 to 9d604b0 Decreases (3 builds for bl702, k32w)
Full report (7 builds for bl702, k32w, qpg)
|
|
PR #23933: Size comparison from f71e778 to 9cc0d2e Increases (28 builds for bl602, cc13x2_26x2, efr32, esp32, linux, psoc6, qpg, telink)
Decreases (9 builds for bl702, cc13x2_26x2, efr32, nrfconnect, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cliffamzn
pushed a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Feb 23, 2023
…t-chip#23933) * Set the cache-flush bit for "unique" records in minimal mdns. There should only be one entity around with a given Matter instance name or Matter hostname, so all records which have those as the QName are part of the unique set. Fixes project-chip#23918 * Fix build issue.
|
This should also be done for _matterc._udp (not only _matter._tcp). May I suggest to call |
|
For |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should only be one entity around with a given Matter instance name or Matter hostname, so all records which have those as the QName are part of the unique set.
Fixes #23918