Allowing chip-repl test to send invalid enum values #24352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #24352: Size comparison from 0807f5e to e959c0a Increases (5 builds for bl602, cc13x2_26x2, esp32, telink)
Decreases (13 builds for bl602, bl702, cc13x2_26x2, esp32, k32w, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis and
franck-apple
tehampson
changed the title
|
PR #24352: Size comparison from 2f0c9ab to 0124265 Increases (10 builds for bl702, psoc6, qpg, telink)
Decreases (10 builds for bl602, bl702, esp32, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jan 18, 2023
|
PR #24352: Size comparison from a912fdc to 0cd4073 Increases (15 builds for bl702, cc13x2_26x2, efr32, esp32, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for cc13x2_26x2, nrfconnect, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
Possible to move the enum.py into the clusters folders/package ? That way it will be included in the clusters wheel, as the custom enum class is meant to be used by the cluster definitions. |
|
PR #24352: Size comparison from 8ad1073 to 09c23e8 Increases (10 builds for bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, cyw30739, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Proof of concept for allowing chip-repl test to send invalid enum values * Prototype after latest round of discussions * Quick cleanup * Moving to properly done version * Couple extra fixes * Remove unneeded global * Add lock for placeholder count * Restyle * add missing regen to cluster-enums.h after merging master * Quick fix * Quick Fix * Restyle
agners
added a commit
to agners/connectedhomeip
that referenced
this pull request
May 23, 2023
The new enum type is required in the Cluster objects. Make it and its dependency part of the Cluster CHIP wheel. Fixes PR project-chip#24352.
agners
added a commit
to agners/connectedhomeip
that referenced
this pull request
May 23, 2023
The new enum type is required in the Cluster objects. Make it and its dependency part of the Cluster CHIP wheel. Fixes PR project-chip#24352.
andy31415
pushed a commit
that referenced
this pull request
May 25, 2023
* [python] make enum part of cluster wheel The new enum type is required in the Cluster objects. Make it and its dependency part of the Cluster CHIP wheel. Fixes PR #24352. * Restyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #24369
This give python the same behaviour that exists in cpp today. When an out of scope enum value is received we map it to kUknownEnumValue. We also provide a way to disable this in someone would like to intentionally disable this behaviour and intentionally get a ValueError.
We also add the ability for chip-repl to extend the enum at runtime. This allows tests to intentionally send out an invalid enum value to see how matter device on the other side behaves when given an out of scope enum value.