[Python] Add Python commissioning flow #25119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erjiaqing
force-pushed
the
repl/python-commissioner
branch
from
3b09daa
to
7336446
Compare
|
PR #25119: Size comparison from 3f99254 to 7336446 Increases (8 builds for bl602, cc32xx, cyw30739, psoc6, telink)
Decreases (6 builds for bl702, esp32, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs and
jmartinez-silabs
|
PR #25119: Size comparison from cad990f to 4f5b153 Increases (10 builds for bl602, bl702, cc13x2_26x2, cc32xx, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (36 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, k32w, linux, nrfconnect, psoc6, qpg, telink)
|
|
PR #25119: Size comparison from 19fbda3 to 7e68837 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
erjiaqing
force-pushed
the
repl/python-commissioner
branch
from
7e68837
to
f1964ff
Compare
|
PR #25119: Size comparison from 19fbda3 to f1964ff Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
|
PR #25119: Size comparison from 19fbda3 to c42acb7 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
erjiaqing
force-pushed
the
repl/python-commissioner
branch
from
c42acb7
to
b4da241
Compare
|
PR #25119: Size comparison from 7e728bc to b4da241 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
erjiaqing
force-pushed
the
repl/python-commissioner
branch
from
b4da241
to
3bb6133
Compare
|
PR #25119: Size comparison from 7e728bc to 3bb6133 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
|
@erjiaqing - flake8 seems to complain about things. If code is correct we can add an exception, otherwise we need to fix things. |
Updated the script to follow flake8's suggestions. |
|
PR #25119: Size comparison from c5f023b to d5b50e7 Increases (1 build for qpg)
Decreases (1 build for cc32xx)
Full report (3 builds for cc32xx, qpg)
|
|
PR #25119: Size comparison from c5f023b to 0e73f29 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
shchen-Lab
added a commit
to bouffalolab/connectedhomeip-1
that referenced
this pull request
Mar 1, 2023
…p-1 into bl702l_matter * 'bl702l_matter' of github.com:bouffalolab/connectedhomeip-1: (446 commits) [Python] Add Python commissioning flow (project-chip#25119) Add to flake8 in workflow and fix python files (project-chip#25280) Align Time Format Localization cluster XML to spec changes. (project-chip#25289) Use the PathsFinder module in scripts/tests/run_test_suite.py instead of having duplicated code (project-chip#25368) Add a continuous browse for Matter operational advertisements on Darwin. (project-chip#25317) Chef doorlock sample update (project-chip#24118) Fix implementation of OnChipScanComplete and OnScanComplete - second PR (project-chip#24873) Add to flake8 in workflow and fix python files (project-chip#25279) Make PASE setup a bit more robust if multiple clients race. (project-chip#25352) Add dependent lib kotlin-stdlib for kotlin version of java-matter-controller (project-chip#25358) [python tests] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25312) Add to flake8 in workflow and fix python files (project-chip#25283) Add a way to read a concrete attribute path from AttributePathIB::Parser. (project-chip#25293) Make sure various tests in TestReadInteraction are not no-ops. (project-chip#25298) [Android] Add isUrgent option in Android (project-chip#25301) [NXP] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25305) [placeholder] Allow applications can specify which additional sources to build (project-chip#25346) Set thread sleep and yield backends for rpc (project-chip#25350) [config-data] Remove some enums that just don't generate anything (project-chip#25370) [Tizen] CI workflow for running QEMU-based tests (project-chip#24871) ...
shchen-Lab
added a commit
to bouffalolab/connectedhomeip-1
that referenced
this pull request
Mar 1, 2023
* official/master: (449 commits) tv-casting-app: Updating the context we pass to FindOrEstablishSession Changing caching logic to match video players using hostname before other attributes Enable -Wconversion tree-wide on darwin. (project-chip#25376) [Python] Add Python commissioning flow (project-chip#25119) Add to flake8 in workflow and fix python files (project-chip#25280) Align Time Format Localization cluster XML to spec changes. (project-chip#25289) Use the PathsFinder module in scripts/tests/run_test_suite.py instead of having duplicated code (project-chip#25368) Add a continuous browse for Matter operational advertisements on Darwin. (project-chip#25317) Chef doorlock sample update (project-chip#24118) Fix implementation of OnChipScanComplete and OnScanComplete - second PR (project-chip#24873) Add to flake8 in workflow and fix python files (project-chip#25279) Make PASE setup a bit more robust if multiple clients race. (project-chip#25352) Add dependent lib kotlin-stdlib for kotlin version of java-matter-controller (project-chip#25358) [python tests] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25312) Add to flake8 in workflow and fix python files (project-chip#25283) Add a way to read a concrete attribute path from AttributePathIB::Parser. (project-chip#25293) Make sure various tests in TestReadInteraction are not no-ops. (project-chip#25298) [Android] Add isUrgent option in Android (project-chip#25301) [NXP] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25305) [placeholder] Allow applications can specify which additional sources to build (project-chip#25346) ...
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* [Python] Add python commissioning flow * Update * Update * Format * Fix * Fix * Update --------- Co-authored-by: yunhanw-google <yunhanw@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24055
This PR introduces manually commissioning flow in Python, with a example of commissioning flow without autocommissioner. This is useful for testing potential commissioning flow changes in the future since it is more flexible. It can also be used to test a few corner cases during commissioning, including bad certificate chain etc.
This PR also splits the Controller in Python into two parts, ControllerBase (like Controller in C++, actually backed with a Commissioner with dummy CertificateIssuer), and Controller (the Commissioner), the ControllerBase can be initialized with a certificate signed by someone else.
This PR only includes changes to Python scripts and necessary C++ interfaces.
The changes to CHIP Tool will be done later in separate PR.