Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag unknown struct fields in chip-tool. #25297

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Flag unknown struct fields in chip-tool. #25297

merged 1 commit into from
Feb 24, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

This helps catch cases when someone mis-types the name of an optional struct field.

Fixes #21892

@github-actions
Copy link

github-actions bot commented Feb 24, 2023 •
edited
Loading

PR #25297: Size comparison from b7e3cbb to 56a21f8

Increases (3 builds for bl702, linux)
platform target config section b7e3cbb 56a21f8 change % change
bl702 lighting-app bl702 .debug_info 40596446 40596447 1 0.0
.text 955380 955382 2 0.0
bl702+rpc .debug_info 45008426 45008427 1 0.0
.text 1030408 1030410 2 0.0
linux chip-tool-ipv6only arm64 (read only) 12106260 12116244 9984 0.1
.rodata 586868 586900 32 0.0
.text 9780740 9790692 9952 0.1
Decreases (1 build for cc32xx)
platform target config section b7e3cbb 56a21f8 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20257011 20257010 -1 -0.0
Full report (10 builds for bl602, bl702, cc32xx, linux, mbed, qpg)
platform target config section b7e3cbb 56a21f8 change % change
bl602 lighting-app bl602 (read/write) 1349822 1349822 0 0.0
.bss 94674 94674 0 0.0
.data 9752 9752 0 0.0
.text 1026034 1026034 0 0.0
bl602+rpc (read/write) 1395238 1395238 0 0.0
.bss 102722 102722 0 0.0
.data 10144 10144 0 0.0
.text 1056966 1056966 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1188171 1188171 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69785 69785 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4080 4080 0 0.0
.debug_abbrev 1551800 1551800 0 0.0
.debug_aranges 134272 134272 0 0.0
.debug_frame 492272 492272 0 0.0
.debug_info 40596446 40596447 1 0.0
.debug_line 5278165 5278165 0 0.0
.debug_loc 3416695 3416695 0 0.0
.debug_ranges 372056 372056 0 0.0
.debug_str 3580026 3580026 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107744 107744 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 574257 574257 0 0.0
.symtab 173632 173632 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
955380 955382 2 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1278375 1278375 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77833 77833 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4624 4624 0 0.0
.debug_abbrev 1700009 1700009 0 0.0
.debug_aranges 142512 142512 0 0.0
.debug_frame 519960 519960 0 0.0
.debug_info 45008426 45008427 1 0.0
.debug_line 5676926 5676926 0 0.0
.debug_loc 3613417 3613417 0 0.0
.debug_ranges 395832 395832 0 0.0
.debug_str 3983563 3983563 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121840 121840 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 635274 635274 0 0.0
.symtab 191968 191968 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1030408 1030410 2 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 642681 642681 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930133 930133 0 0.0
.debug_aranges 87304 87304 0 0.0
.debug_frame 299872 299872 0 0.0
.debug_info 20257011 20257010 -1 -0.0
.debug_line 2656183 2656183 0 0.0
.debug_loc 2797535 2797535 0 0.0
.debug_ranges 281792 281792 0 0.0
.debug_str 3023459 3023459 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105769 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256256 256256 0 0.0
.text 0 0 0 0.0
534788 534788 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12106260 12116244 9984 0.1
(read/write) 732616 732616 0 0.0
.bss 34136 34136 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 674896 674896 0 0.0
.dynamic 560 560 0 0.0
.got 15368 15368 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 586868 586900 32 0.0
.text 9780740 9790692 9952 0.1
thermostat-no-ble arm64 (read only) 2515868 2515868 0 0.0
(read/write) 145064 145064 0 0.0
.bss 56328 56328 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77568 77568 0 0.0
.dynamic 560 560 0 0.0
.got 5336 5336 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150552 150552 0 0.0
.text 2103248 2103248 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467168 2467168 0 0.0
.bss 215788 215788 0 0.0
.data 5880 5880 0 0.0
.text 1429812 1429812 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151340 1151340 0 0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598436 598436 0 0.0
lock-app qpg6105+debug (read/write) 1118540 1118540 0 0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565640 565640 0 0.0

@bzbarsky-apple
Flag unknown struct fields in chip-tool.
b61ea18 
This helps catch cases when someone mis-types the name of an optional struct
field.

Fixes project-chip#21892
@github-actions
Copy link

PR #25297: Size comparison from b7e3cbb to b61ea18

Decreases (1 build for cc32xx)
platform target config section b7e3cbb b61ea18 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20257011 20257009 -2 -0.0
Full report (1 build for cc32xx)
platform target config section b7e3cbb b61ea18 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642681 642681 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930133 930133 0 0.0
.debug_aranges 87304 87304 0 0.0
.debug_frame 299872 299872 0 0.0
.debug_info 20257011 20257009 -2 -0.0
.debug_line 2656183 2656183 0 0.0
.debug_loc 2797535 2797535 0 0.0
.debug_ranges 281792 281792 0 0.0
.debug_str 3023459 3023459 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105769 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256256 256256 0 0.0
.text 534788 534788 0 0.0

@andy31415 andy31415 merged commit 50edd9f into project-chip:master Feb 24, 2023
@bzbarsky-apple bzbarsky-apple deleted the flag-unknown-struct-fields branch February 24, 2023 14:57
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Flag unknown struct fields in chip-tool. (project-chip#25297)
c0c532a 
This helps catch cases when someone mis-types the name of an optional struct
field.

Fixes project-chip#21892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@vivien-apple vivien-apple vivien-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
examples review - approved tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chip-tool accesscontrol write acl accepts any random arguments
3 participants
@bzbarsky-apple @andy31415 @vivien-apple