-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch the color control move/step enums to enum class. #25624
Switch the color control move/step enums to enum class. #25624
Conversation
Gets us some type safety and removes some of the confusion where we were switching on a thing called moveMode but comparing it to move direction values.
6bed4b3
to
de07732
Compare
PR #25624: Size comparison from be24854 to de07732 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
Would to want to add the Enum suffix on these enums now and then I can use these names when I do the editorial on these app clusters? |
Note that the exact set of enums that will be defined here in the spec is not entirely clear to me; it might not match what is currently in our XML at all... So I would rather not mess with the XML until the spec is actually updated @ReneJosefsen . |
…#25624) Gets us some type safety and removes some of the confusion where we were switching on a thing called moveMode but comparing it to move direction values.
…#25624) Gets us some type safety and removes some of the confusion where we were switching on a thing called moveMode but comparing it to move direction values.
Gets us some type safety and removes some of the confusion where we were switching on a thing called moveMode but comparing it to move direction values.