Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the color control move/step enums to enum class. #25624

Conversation

bzbarsky-apple
Copy link
Contributor

Gets us some type safety and removes some of the confusion where we were switching on a thing called moveMode but comparing it to move direction values.

Gets us some type safety and removes some of the confusion where we were
switching on a thing called moveMode but comparing it to move direction values.
@bzbarsky-apple bzbarsky-apple force-pushed the strongly-type-move-step-color-control-enums branch from 6bed4b3 to de07732 Compare March 10, 2023 17:58
@github-actions
Copy link

PR #25624: Size comparison from be24854 to de07732

Increases (1 build for cc32xx)
platform target config section be24854 de07732 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_str 3026158 3026947 789 0.0
Decreases (1 build for cc32xx)
platform target config section be24854 de07732 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20275630 20245938 -29692 -0.1
.debug_line 2660982 2660975 -7 -0.0
.debug_loc 2804957 2804896 -61 -0.0
Full report (1 build for cc32xx)
platform target config section be24854 de07732 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645097 645097 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20275630 20245938 -29692 -0.1
.debug_line 2660982 2660975 -7 -0.0
.debug_loc 2804957 2804896 -61 -0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026158 3026947 789 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379204 379204 0 0.0
.symtab 256912 256912 0 0.0
.text 536984 536984 0 0.0

@ReneJosefsen
Copy link
Contributor

Would to want to add the Enum suffix on these enums now and then I can use these names when I do the editorial on these app clusters?

@bzbarsky-apple
Copy link
Contributor Author

Note that the exact set of enums that will be defined here in the spec is not entirely clear to me; it might not match what is currently in our XML at all... So I would rather not mess with the XML until the spec is actually updated @ReneJosefsen .

@yufengwangca yufengwangca merged commit bcb0708 into project-chip:master Mar 13, 2023
@bzbarsky-apple bzbarsky-apple deleted the strongly-type-move-step-color-control-enums branch March 13, 2023 18:25
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
…#25624)

Gets us some type safety and removes some of the confusion where we were
switching on a thing called moveMode but comparing it to move direction values.
mwswartwout pushed a commit to mwswartwout/connectedhomeip that referenced this pull request Mar 27, 2023
…#25624)

Gets us some type safety and removes some of the confusion where we were
switching on a thing called moveMode but comparing it to move direction values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants