Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add ProductAppearance attribute support. (#24415)" #25740

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Revert "Add ProductAppearance attribute support. (#24415)" #25740

merged 1 commit into from
Mar 20, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

This reverts commit 7f8dfe8.

This attribute is not in the spec yet, and the PR should not have been merged.

@bzbarsky-apple
Revert "Add ProductAppearance attribute support. (project-chip#24415)"
4251696 
This reverts commit 7f8dfe8.

This attribute is not in the spec yet, and the PR should not have been merged.
@bzbarsky-apple bzbarsky-apple added the hotfix urgent fix needed, can bypass review label Mar 19, 2023
@github-actions
Copy link

PR #25740: Size comparison from 3edd101 to 4251696

Decreases (1 build for cc32xx)
platform target config section 3edd101 4251696 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 645945 645601 -344 -0.1
.debug_abbrev 930399 930289 -110 -0.0
.debug_aranges 87520 87400 -120 -0.1
.debug_frame 300716 300316 -400 -0.1
.debug_info 20265057 20248009 -17048 -0.1
.debug_line 2663587 2661469 -2118 -0.1
.debug_loc 2808805 2805592 -3213 -0.1
.debug_ranges 283608 283208 -400 -0.1
.debug_str 3036926 3027174 -9752 -0.3
.rodata 106009 105993 -16 -0.0
.strtab 381423 380421 -1002 -0.3
.symtab 257664 257408 -256 -0.1
.text 537816 537488 -328 -0.1
Full report (1 build for cc32xx)
platform target config section 3edd101 4251696 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645945 645601 -344 -0.1
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930399 930289 -110 -0.0
.debug_aranges 87520 87400 -120 -0.1
.debug_frame 300716 300316 -400 -0.1
.debug_info 20265057 20248009 -17048 -0.1
.debug_line 2663587 2661469 -2118 -0.1
.debug_loc 2808805 2805592 -3213 -0.1
.debug_ranges 283608 283208 -400 -0.1
.debug_str 3036926 3027174 -9752 -0.3
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106009 105993 -16 -0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 381423 380421 -1002 -0.3
.symtab 257664 257408 -256 -0.1
.text 537816 537488 -328 -0.1

@yufengwangca
Copy link
Contributor

Sorry for miss merging the PR

@bzbarsky-apple bzbarsky-apple merged commit 2767b51 into project-chip:master Mar 20, 2023
@bzbarsky-apple bzbarsky-apple deleted the revert-product-appearance branch March 20, 2023 03:57
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Revert "Add ProductAppearance attribute support. (project-chip#24415)" (
5c0c21a 
project-chip#25740)

This reverts commit 7f8dfe8.

This attribute is not in the spec yet, and the PR should not have been merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufengwangca yufengwangca yufengwangca approved these changes

Assignees
No one assigned
Labels
app controller darwin examples hotfix urgent fix needed, can bypass review platform tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bzbarsky-apple @yufengwangca