Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Silabs] Remove groups cluster from endpoint 0 on our lighting-app zap configs #26106

Merged

Conversation

jmartinez-silabs
Copy link
Member

fixes #26065

TC_RR_1.1 was failing on the silabs lighting app. CHIP_CONFIG_MAX_GROUP_ENDPOINTS_PER_FABRIC is set to 1 by default and our lighting app had the groups cluster on endpoint 0 and endpoint 1.
You can define CHIP_CONFIG_MAX_GROUP_ENDPOINTS_PER_FABRIC to what your app needs, but more importantly, groups shouldn't be on endpoint 0. I believe it was used for some tests at the time.

This PR removes the groups cluster from endpoint 0.

@github-actions
Copy link

PR #26106: Size comparison from cdf3c61 to 0b553c1

Increases (1 build for qpg)
platform target config section cdf3c61 0b553c1 change % change
qpg lighting-app qpg6105+debug (read/write) 1166624 1166632 8 0.0
.text 613724 613732 8 0.0
Full report (2 builds for qpg)
platform target config section cdf3c61 0b553c1 change % change
qpg lighting-app qpg6105+debug (read/write) 1166624 1166632 8 0.0
.bss 99308 99308 0 0.0
.data 856 856 0 0.0
.text 613724 613732 8 0.0
lock-app qpg6105+debug (read/write) 1136704 1136704 0 0.0
.bss 94452 94452 0 0.0
.data 860 860 0 0.0
.text 583800 583800 0 0.0

@yufengwangca yufengwangca merged commit ff55823 into project-chip:master Apr 14, 2023
@jmartinez-silabs jmartinez-silabs deleted the fix/tc_rr_1.1_failure branch April 14, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] TC-RC-1.1 failing at Step 11
4 participants