make build succeed on Catalina with Xcode 12.00. #26378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
PR #26378: Size comparison from a59ffbd to fc5a4cf Full report (4 builds for cc32xx, mbed, qpg)
|
bzbarsky-apple
approved these changes
May 5, 2023
|
PR #26378: Size comparison from a59ffbd to 8a8f0aa Increases above 0.2%:
Increases (4 builds for bl702, cc32xx, nrfconnect)
Decreases (3 builds for bl702, qpg)
Full report (11 builds for bl602, bl702, cc32xx, mbed, nrfconnect, qpg)
|
emargolis
approved these changes
May 5, 2023
pullapprove
bot
requested review from
amitnj,
arkq,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
kkasperczyk-no
pullapprove
bot
requested review from
lazarkov,
lpbeliveau-silabs,
LuDuda,
msandstedt,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
vijs,
xylophone21 and
younghak-hwang
|
PR #26378: Size comparison from a59ffbd to 348f9ff Increases above 0.2%:
Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
|
@mplitkins Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pulling a fresh fork of the repo under Catalina:
Version 10.15.7 (19H2026)
using Xcode:
mmpmbp01:~ michaelp$ clang --version
Apple clang version 12.0.0 (clang-1200.0.32.29)
Target: x86_64-apple-darwin19.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
I had the following two errors pop up when building the tree:
[4077/8401] c++ mac_x64_gcc/obj/src/tools/chip-cert/chip-cert.GeneralUtils.cpp.o
FAILED: mac_x64_gcc/obj/src/tools/chip-cert/chip-cert.GeneralUtils.cpp.o
g++ -MMD -MF mac_x64_gcc/obj/src/tools/chip-cert/chip-cert.GeneralUtils.cpp.o.d -Wconversion -target x86_64-apple-macos11.0 -O0 -g2 -fno-common -ffunction-sections -fdata-sections -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -Wall -Werror -Wextra -Wshadow -Wunreachable-code -Wvla -Wformat -Wformat-nonliteral -Wformat-security -Wconversion -Wno-deprecated-declarations -Wno-missing-field-initializers -Wno-unknown-warning-option -Wno-unused-parameter -Wno-cast-function-type -Wno-psabi -Wno-maybe-uninitialized -fdiagnostics-color -fno-strict-aliasing -fmacro-prefix-map=../../= -fobjc-arc -Wconversion -std=gnu++14 -frtti -Wnon-virtual-dtor -DCHIP_HAVE_CONFIG_H=1 -DOPENSSL_NO_ASM=1 -I../../src/include -I../../src -Imac_x64_gcc/gen/include -I../../zzz_generated/app-common -I../../config/standalone -I../../third_party/nlassert/repo/include -I../../third_party/nlio/repo/include -I../../third_party/nlfaultinjection/repo/include -I../../third_party/boringssl/repo/src/include -c ../../src/tools/chip-cert/GeneralUtils.cpp -o mac_x64_gcc/obj/src/tools/chip-cert/chip-cert.GeneralUtils.cpp.o
../../src/tools/chip-cert/GeneralUtils.cpp:237:75: error: use of undeclared identifier 'errno'
fprintf(stderr, "Unable to open %s: %s\n", fileName, strerror(errno));
^
../../src/tools/chip-cert/GeneralUtils.cpp:273:70: error: use of undeclared identifier 'errno'
fprintf(stderr, "Error reading %s: %s\n", fileName, strerror(errno));
^
../../src/tools/chip-cert/GeneralUtils.cpp:286:74: error: use of undeclared identifier 'errno'
fprintf(stderr, "Error reading %s: %s\n", fileName, strerror(errno));
^
../../src/tools/chip-cert/GeneralUtils.cpp:338:90: error: use of undeclared identifier 'errno'
fprintf(stderr, "Unable to write to %s: %s\n", fileName, strerror(ferror(file) ? errno : ENOSPC));
^
../../src/tools/chip-cert/GeneralUtils.cpp:338:98: error: use of undeclared identifier 'ENOSPC'
fprintf(stderr, "Unable to write to %s: %s\n", fileName, strerror(ferror(file) ? errno : ENOSPC));
^
../../src/tools/chip-cert/GeneralUtils.cpp:345:90: error: use of undeclared identifier 'errno'
fprintf(stderr, "Unable to write to %s: %s\n", fileName, strerror(ferror(file) ? errno : ENOSPC));
^
../../src/tools/chip-cert/GeneralUtils.cpp:345:98: error: use of undeclared identifier 'ENOSPC'
fprintf(stderr, "Unable to write to %s: %s\n", fileName, strerror(ferror(file) ? errno : ENOSPC));
^
7 errors generated.
[4094/8401] c++ mac_x64_gcc/obj/examples/chip-tool/chip-tool.main.cpp.o
ninja: build stopped: subcommand failed.
[1959/4312] c++ standalone/obj/examples/platform/linux/app-main.NamedPipeCommands.cpp.o
FAILED: standalone/obj/examples/platform/linux/app-main.NamedPipeCommands.cpp.o
g++ -MMD -MF standalone/obj/examples/platform/linux/app-main.NamedPipeCommands.cpp.o.d -target x86_64-apple-macos11.0 -O0 -g2 -fno-common -ffunction-sections -fdata-sections -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -Wall -Werror -Wextra -Wshadow -Wunreachable-code -Wvla -Wformat -Wformat-nonliteral -Wformat-security -Wconversion -Wno-deprecated-declarations -Wno-missing-field-initializers -Wno-unknown-warning-option -Wno-unused-parameter -Wno-cast-function-type -Wno-psabi -Wno-maybe-uninitialized -fdiagnostics-color -fno-strict-aliasing -fmacro-prefix-map=../../= -fobjc-arc -Wconversion -std=gnu++14 -frtti -Wnon-virtual-dtor -DCHIP_HAVE_CONFIG_H=1 -DOPENSSL_NO_ASM=1 -DCHIP_ADDRESS_RESOLVE_IMPL_INCLUDE_HEADER=<lib/address_resolve/AddressResolve_DefaultImpl.h> -I../../examples/platform/linux -I../../examples/providers -I../../src/include -I../../src -Istandalone/gen/include -I../../zzz_generated/app-common -I../../config/standalone -I../../third_party/nlassert/repo/include -I../../third_party/nlio/repo/include -I../../third_party/boringssl/repo/src/include -I../../examples/common/tracing -I../../third_party/jsoncpp/repo/include -c ../../examples/platform/linux/NamedPipeCommands.cpp -o standalone/obj/examples/platform/linux/app-main.NamedPipeCommands.cpp.o
../../examples/platform/linux/NamedPipeCommands.cpp:40:63: error: use of undeclared identifier 'errno'
VerifyOrReturnError((mkfifo(path.c_str(), 0666) == 0) || (errno == EEXIST), CHIP_ERROR_OPEN_FAILED);
^
../../examples/platform/linux/NamedPipeCommands.cpp:40:72: error: use of undeclared identifier 'EEXIST'
VerifyOrReturnError((mkfifo(path.c_str(), 0666) == 0) || (errno == EEXIST), CHIP_ERROR_OPEN_FAILED);
^
2 errors generated.
[1976/4312] ACTION //examples/thermostat/thermostat-common:thermostat-common_zapgen_zap_pregen(//config/standalone/toolchain:standalone)
ninja: build stopped: subcommand failed.
By simply adding:
#include <errno.h>
to the two source files the issues were resolved.
Rob Szewczyk chimed in via email and added the following bit of information from a system that did not run into these issues:
"
This is the chain of includes that makes it work on the system without embedding your patch:
. ../../src/tools/chip-cert/chip-cert.h
.. /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/memory
... /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__memory/shared_ptr.h
.... /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/atomic
..... /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__threading_support
...... /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/errno.h
....... /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/errno.h
........ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/errno.h
The above was generated with
g++ -H -MMD -MF mac_x64_gcc/obj/src/tools/chip-cert/chip-cert.GeneralUtils.cpp.o.d -Wconversion -target x86_64-apple-macos11.0 -O0 -g2 -fno-common -ffunction-sections -fdata-sections -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -Wall -Werror -Wextra -Wshadow -Wunreachable-code -Wvla -Wformat -Wformat-nonliteral -Wformat-security -Wconversion -Wno-deprecated-declarations -Wno-missing-field-initializers -Wno-unknown-warning-option -Wno-unused-parameter -Wno-cast-function-type -Wno-psabi -Wno-maybe-uninitialized -fdiagnostics-color -fno-strict-aliasing -fmacro-prefix-map=../../= -fobjc-arc -Wconversion -std=gnu++14 -frtti -Wnon-virtual-dtor -DCHIP_HAVE_CONFIG_H=1 -DOPENSSL_NO_ASM=1 -I../../src/include -I../../src -Imac_x64_gcc/gen/include -I../../zzz_generated/app-common -I../../config/standalone -I../../third_party/nlassert/repo/include -I../../third_party/nlio/repo/include -I../../third_party/nlfaultinjection/repo/include -I../../third_party/boringssl/repo/src/include -E ../../src/tools/chip-cert/GeneralUtils.cpp -o mac_x64_gcc/obj/src/tools/chip-cert/chip-cert.GeneralUtils.cpp.E
I had also generated a pre-processed GeneralUtils.cpp.E which I am attaching below.
rob
"