Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up dependencies of //examples/platform/linux:app-main #26408

Merged
merged 5 commits into from
May 12, 2023

Conversation

ksperling-apple
Copy link
Contributor

@ksperling-apple ksperling-apple commented May 8, 2023

Tidy up dependencies of //examples/platform/linux:app-main and tv-app / tv-casting-app

  • Use deps instead of public_deps where possible
  • Only build shell commands if chip_build_libshell is true
  • Remove explicit //src/lib/shell dependencies, it's already pulled in by //src/lib
  • Remove CommonRpc.h which is an identical copy of Rpc.h

Also run zap_cluster_list.py directly instead of through gn_run_binary.py

@github-actions
Copy link

github-actions bot commented May 8, 2023

PR #26408: Size comparison from 6c0c5ea to d166080

Increases (6 builds for bl602, bl702, cc32xx, nrfconnect)
platform target config section 6c0c5ea d166080 change % change
bl602 lighting-app bl602 .text 1036046 1036048 2 0.0
bl602+rpc .text 1067402 1067406 4 0.0
bl702 lighting-app bl702+rpc .debug_info 45541035 45541036 1 0.0
.text 1037586 1037588 2 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19609755 19609756 1 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 807316 807320 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 778252 778256 4 0.0
Decreases (1 build for bl702)
platform target config section 6c0c5ea d166080 change % change
bl702 lighting-app bl702 .debug_info 40844341 40844340 -1 -0.0
.text 965196 965194 -2 -0.0
Full report (11 builds for bl602, bl702, cc32xx, mbed, nrfconnect, qpg)
platform target config section 6c0c5ea d166080 change % change
bl602 lighting-app bl602 (read/write) 1355098 1355098 0 0.0
.bss 87886 87886 0 0.0
.data 9648 9648 0 0.0
.text 1036046 1036048 2 0.0
bl602+rpc (read/write) 1401374 1401374 0 0.0
.bss 95934 95934 0 0.0
.data 10040 10040 0 0.0
.text 1067402 1067406 4 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1185471 1185471 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67585 67585 0 0.0
.bss_psram 24368 24368 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1550070 1550070 0 0.0
.debug_aranges 132808 132808 0 0.0
.debug_frame 487996 487996 0 0.0
.debug_info 40844341 40844340 -1 -0.0
.debug_line 5294433 5294433 0 0.0
.debug_loc 3418815 3418815 0 0.0
.debug_ranges 372064 372064 0 0.0
.debug_str 3684696 3684696 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106288 106288 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 580845 580845 0 0.0
.symtab 175232 175232 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 965196 965194 -2 -0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1273043 1273043 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75633 75633 0 0.0
.bss_psram 24768 24768 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1703394 1703394 0 0.0
.debug_aranges 141032 141032 0 0.0
.debug_frame 515888 515888 0 0.0
.debug_info 45541035 45541036 1 0.0
.debug_line 5703864 5703864 0 0.0
.debug_loc 3619825 3619825 0 0.0
.debug_ranges 397096 397096 0 0.0
.debug_str 4109105 4109105 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120128 120128 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 641389 641389 0 0.0
.symtab 193520 193520 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1037586 1037588 2 0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605090 605090 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957621 957621 0 0.0
.debug_aranges 101136 101136 0 0.0
.debug_frame 341512 341512 0 0.0
.debug_info 19609755 19609756 1 0.0
.debug_line 2666632 2666632 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1489225 1489225 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94315 94315 0 0.0
.debug_str 3108982 3108982 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104354 104354 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483384 483384 0 0.0
.symtab 287328 287328 0 0.0
.text 498612 498612 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2495160 2495160 0 0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1457844 1457844 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1176420 1176420 0 0.0
bss 155563 155563 0 0.0
rodata 132788 132788 0 0.0
text 807316 807320 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1123528 1123528 0 0.0
bss 154757 154757 0 0.0
rodata 109784 109784 0 0.0
text 778252 778256 4 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1436132 1436132 0 0.0
bss 135303 135303 0 0.0
rodata 228804 228804 0 0.0
text 777956 777956 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1167976 1167976 0 0.0
.bss 99632 99632 0 0.0
.data 856 856 0 0.0
.text 615076 615076 0 0.0
lock-app qpg6105+debug (read/write) 1137344 1137344 0 0.0
.bss 94784 94784 0 0.0
.data 852 852 0 0.0
.text 584440 584440 0 0.0

- Use deps instead of public_deps where possible
- Only build shell commands if chip_build_libshell is true
- Remove explicit //src/lib/shell dependencies, it's already pulled in by //src/lib
@andy31415 andy31415 merged commit 567b797 into project-chip:master May 12, 2023
49 checks passed
@ksperling-apple ksperling-apple deleted the app-main-deps-cleanup branch September 12, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants